Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nextpnr: fix build on Darwin #104682

Closed
wants to merge 1 commit into from
Closed

nextpnr: fix build on Darwin #104682

wants to merge 1 commit into from

Conversation

Luflosi
Copy link
Contributor

@Luflosi Luflosi commented Nov 23, 2020

Motivation for this change

QT513 and above is broken on Darwin. libsForQt5 automatically uses libsForQt512 on Darwin. nextpnr seems to work fine with the latest QT version on Linux.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Luflosi
nextpnr: fix build on Darwin
edb10b0 
QT513 and above is broken on Darwin. `libsForQt5` automatically uses `libsForQt512` on Darwin. nextpnr seems to work fine with the latest QT version on Linux.
@veprbl
Copy link
Member

veprbl commented Nov 23, 2020

QT513 and above is broken on Darwin

At least qtbase should be working right now.

See green builds for:
https://hydra.nixos.org/job/nixpkgs/trunk/nextpnr.x86_64-darwin

@Luflosi
Copy link
Contributor Author

Luflosi commented Nov 23, 2020

Sorry about that, it's been a few weeks since I last checked, that it's actually broken on Darwin.
I will update the title and commit description to be more accurate.

@Luflosi
Copy link
Contributor Author

Luflosi commented Nov 23, 2020

I made a new PR to replace this one: #104687.

@Luflosi Luflosi closed this Nov 23, 2020
@Luflosi Luflosi deleted the darwin-fix-nextpnr branch November 23, 2020 17:07
@SuperSandro2000
Copy link
Member

Next time please update this PR.

@Luflosi
Copy link
Contributor Author

Luflosi commented Nov 23, 2020

I wanted to change the branch name since it was no longer accurate but unfortunately that's not possible, so I made a new PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Luflosi @veprbl @SuperSandro2000