New flex aspect ratio test #26617
Merged
New flex aspect ratio test #26617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wpt-pr-bot
requested review from
cbiesinger,
fantasai,
kojiishi,
mrego,
plinss,
rachelandrew and
tabatkins
mrego
requested changes
Nov 23, 2020
| <title>CSS Flexible Box Test: Aspect ratio handling of images</title> | ||
| <link rel="author" title="Sergio Villar Senin" href="mailto:svillar@igalia.com" /> | ||
| <link rel="help" href="https://drafts.csswg.org/css-flexbox-1/#algo-cross-item" /> | ||
| <link rel="match" href="reference/flex-aspect-ratio-img-row-014.xht" /> |
There was a problem hiding this comment.
This doesn't match the name of the expected file. Please rename it.
There was a problem hiding this comment.
See most recent patch
| @@ -0,0 +1,26 @@ | |||
| <!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Strict//EN" "http://www.w3.org/TR/xhtml1/DTD/xhtml1-strict.dtd"> | |||
There was a problem hiding this comment.
-expected is common in WebKit, but not really in WPT.
BTW, why are you using XHTML here instead of just HTML with '` like in the test?
There was a problem hiding this comment.
Hmm just because I use some other as reference to create the expectation.
| <style type="text/css"><
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was inspired by the case case in this WebKit bug. Basically we have a flex item with aspect ratio with specified percentage width (the percentage is actually not relevant as the width of the flex container is fixed). WebKit was stretching the image on the block axis till reaching the viewport size because the height of the container was auto and it was not considering the aspet ratio.