Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parted: build with python3 #104703

Merged
merged 1 commit into from Nov 30, 2020
Merged

parted: build with python3 #104703

merged 1 commit into from Nov 30, 2020

Conversation

raboof
Copy link
Member

@raboof raboof commented Nov 23, 2020

Motivation for this change

Moving away from python2. Seems to work at first glance, and
http://www.linuxfromscratch.org/blfs/view/svn/postlfs/parted.html
also suggests it should be possible to use on a system with
only python3.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@veprbl veprbl added this to Needs review in Python 2 deprecation Nov 23, 2020
@SuperSandro2000
Copy link
Member

SuperSandro2000 commented Nov 23, 2020 •
edited

Would you mind adding yourself as a maintainer? The package currently has none.

@SuperSandro2000
Copy link
Member

Lets wait for ofborg but I think this is going to be a mass rebuild.

@raboof
Copy link
Member Author

raboof commented Nov 23, 2020

Would you mind adding yourself as a maintainer? The package currently has none.

I'm not sure I feel qualified to be quite honest...

@jonringer
Copy link
Contributor

Would you mind adding yourself as a maintainer? The package currently has none.

I think if someone is helping to improve an existing package, they don't really need to claim maintainer ship. But if they were to add more packages, then I think that warrents someone to assume maintainership

@raboof raboof changed the base branch from master to staging November 24, 2020 13:51
@raboof raboof mentioned this pull request Nov 30, 2020
Closed
10 tasks
@Mic92 Mic92 merged commit 9f78d4c into NixOS:staging Nov 30, 2020
Python 2 deprecation automation moved this from Needs review to Done Nov 30, 2020
@zimbatm zimbatm added this to In progress in R13y via automation Dec 1, 2020
@Artturin Artturin moved this from In progress to Done in R13y Oct 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 approved these changes

@lukegb lukegb lukegb approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 101-500
Projects
Python 2 deprecation
  
Done
R13y
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@raboof @SuperSandro2000 @jonringer @Mic92 @lukegb