Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

yed: mark as broken if jre.gtk3 is not available #104698

Merged
merged 1 commit into from Nov 23, 2020
Merged

yed: mark as broken if jre.gtk3 is not available #104698

merged 1 commit into from Nov 23, 2020

Conversation

veprbl
Copy link
Member

@veprbl veprbl commented Nov 23, 2020

This cleans up nixpkgs-review report on darwin

Motivation for this change

Should remove a following message seen in nixpkgs-review on macOS:

error: while querying the derivation named 'yEd-3.20.1':
while evaluating the attribute 'buildInputs' of the derivation 'yEd-3.20.1' at ~/.cache/nixpkgs-review/rev-31487784f9ae66e715b2df1e7727119890d05a39-dirty/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:192:11:
while evaluating 'getOutput' at ~/.cache/nixpkgs-review/rev-31487784f9ae66e715b2df1e7727119890d05a39-dirty/nixpkgs/lib/attrsets.nix:464:23, called from undefined position:
while evaluating anonymous function at ~/.cache/nixpkgs-review/rev-31487784f9ae66e715b2df1e7727119890d05a39-dirty/nixpkgs/pkgs/stdenv/generic/make-derivation.nix:143:17, called from undefined position:
attribute 'gtk3' missing, at ~/.cache/nixpkgs-review/rev-31487784f9ae66e715b2df1e7727119890d05a39-dirty/nixpkgs/pkgs/applications/graphics/yed/default.nix:14:19
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

SuperSandro2000
SuperSandro2000 reviewed Nov 23, 2020
View reviewed changes
pkgs/applications/graphics/yed/default.nix
@@ -35,5 +35,6 @@ stdenv.mkDerivation rec {
description = "A powerful desktop application that can be used to quickly and effectively generate high-quality diagrams";
platforms = jre.meta.platforms;
maintainers = with maintainers; [ abbradar ];
broken = !("gtk3" ? jre);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure on the expression but that error is annoying on darwin.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ummmmmmm. This breaks on all systems. It must be jre ? gtk3 and not the other way around!

@veprbl
Copy link
Member Author

veprbl commented Nov 23, 2020 •
edited

When running nixpkgs-review 2.4.2 on this, it will report 128 new packages with names that start with letters "y" and "z" (basically everything that follows after "yed").

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104698 run on x86_64-darwin 1

@SuperSandro2000
Copy link
Member

I will let ofborg finish and then merge this.

@veprbl
yed: mark as broken if jre.gtk3 is not available
91e1cc1 
This cleans up nixpkgs-review report on darwin
@r-burns
Copy link
Contributor

r-burns commented Nov 23, 2020

See #104572 - feel free to mark as broken for now, but I will try to get it working later today

@SuperSandro2000 SuperSandro2000 merged commit d06276e into NixOS:master Nov 23, 2020
@veprbl veprbl deleted the pr/yed_mark_broken branch November 23, 2020 20:57
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104698 run on x86_64-darwin 1

@veprbl veprbl restored the pr/yed_mark_broken branch December 1, 2020 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dasJ dasJ dasJ left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@veprbl @SuperSandro2000 @r-burns @dasJ