Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bat: 0.16.0 -> 0.17.0 #104688

Merged
merged 1 commit into from Nov 23, 2020
Merged

bat: 0.16.0 -> 0.17.0 #104688

merged 1 commit into from Nov 23, 2020

Conversation

06kellyjac
Copy link
Member

@06kellyjac 06kellyjac commented Nov 23, 2020 •
edited

Motivation for this change

Bump bat to 0.17.0

ping:
@dywedir @lilyball @zowoq

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS (x86_64)
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@06kellyjac
Copy link
Member Author

Result of nixpkgs-review pr 104688 1

7 packages built:
  • bat
  • bat-extras.batdiff
  • bat-extras.batgrep
  • bat-extras.batman
  • bat-extras.batwatch
  • bat-extras.prettybat
  • neuron-notes

@06kellyjac
Copy link
Member Author

I've only manually checked bat

@SuperSandro2000
Copy link
Member

Eval failure is fixed hopefully fixed by #104697.

@06kellyjac
Copy link
Member Author

hmm, I didn't get an eval failure. Was that in ofborg or when you ran it?

@SuperSandro2000
Copy link
Member

hmm, I didn't get an eval failure. Was that in ofborg or when you ran it?

Failure in ofborg.

@SuperSandro2000
Copy link
Member

#104697 got merged. You can now rebase and it should hopefully be fixed.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104688 run on x86_64-darwin 1

6 packages built:
  • bat
  • bat-extras.batdiff
  • bat-extras.batgrep
  • bat-extras.batman
  • bat-extras.batwatch
  • bat-extras.prettybat

@06kellyjac
Copy link
Member Author

Result of nixpkgs-review pr 104688 1

7 packages built:
  • bat
  • bat-extras.batdiff
  • bat-extras.batgrep
  • bat-extras.batman
  • bat-extras.batwatch
  • bat-extras.prettybat
  • neuron-notes

@jonringer
Copy link
Contributor

however, ofborg seems to slowed to a very slow crawl. I apologize

@ofborg ofborg bot requested review from zowoq, dywedir and lilyball November 23, 2020 21:16
@zowoq zowoq merged commit f7876c6 into NixOS:master Nov 23, 2020
@06kellyjac 06kellyjac deleted the bat branch November 24, 2020 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zowoq zowoq Awaiting requested review from zowoq

@dywedir dywedir Awaiting requested review from dywedir

@lilyball lilyball Awaiting requested review from lilyball

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@06kellyjac @SuperSandro2000 @jonringer @zowoq