Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nextpnr: unpin Qt version #104687

Merged
merged 1 commit into from Nov 24, 2020
Merged

nextpnr: unpin Qt version #104687

merged 1 commit into from Nov 24, 2020

Conversation

Luflosi
Copy link
Contributor

@Luflosi Luflosi commented Nov 23, 2020

Motivation for this change

The current version of nextpnr works fine with the latest QT version.
It was pinned to Qt 5.14 in 22167ae.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Luflosi Luflosi mentioned this pull request Nov 23, 2020
Closed
10 tasks
@veprbl
Copy link
Member

veprbl commented Nov 23, 2020

@GrahamcOfBorg eval

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104687 run on x86_64-darwin 1

1 package built:
  • nextpnr

@SuperSandro2000
Copy link
Member

CI failures are unrelated. Can you nevertheless please rebase on master?

@Luflosi
Copy link
Contributor Author

Luflosi commented Nov 23, 2020

Sure.

@Luflosi
nextpnr: unpin Qt version
0f8801c 
The current version of nextpnr works fine with the latest QT version.
It was pinned to Qt 5.14 in 22167ae.
@veprbl
Copy link
Member

veprbl commented Nov 23, 2020

@GrahamcOfBorg eval

veprbl
veprbl approved these changes Nov 23, 2020
View reviewed changes
Copy link
Member

@veprbl veprbl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds on x86_64-darwin

@veprbl veprbl merged commit b70bbd9 into NixOS:master Nov 24, 2020
@Luflosi Luflosi deleted the nextpnr-unpin-qt-version branch November 24, 2020 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veprbl veprbl veprbl approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Luflosi @veprbl @SuperSandro2000