Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

voxelands: 1512.00 -> 1704.00 #104705

Merged
merged 1 commit into from Nov 27, 2020
Merged

voxelands: 1512.00 -> 1704.00 #104705

merged 1 commit into from Nov 27, 2020

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented Nov 23, 2020 •
edited

Motivation for this change

Version update, Repo change URL change

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@prusnak prusnak mentioned this pull request Nov 23, 2020
Closed
jonringer
jonringer reviewed Nov 24, 2020
View reviewed changes
pkgs/games/voxelands/default.nix Outdated
cmake irrlicht libpng bzip2 libjpeg sqlite
libXxf86vm libGLU libGL openal libvorbis xlibsWrapper pkgconfig
bzip2
cmake
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmake and pkg-config should be in nativeBuildInputs

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed in 45f32f9e82b79d49c1b11e1c4630463cbde14168

@doronbehar
Copy link
Contributor

It fails on aarch64 https://logs.nix.ci/?key=nixos/nixpkgs.104705&attempt_id=ce623944-0fb0-4184-8afb-3211576e4a57

Perhaps it should be marked as broken for this system?

@prusnak
Copy link
Member Author

prusnak commented Nov 24, 2020 •
edited

Perhaps it should be marked as broken for this system?

This seems more like a issue with Irrlicht engine on aarch64 - see https://sourceforge.net/p/irrlicht/bugs/443/ (irrlich thinks the system libpng was compiled with NEON instructions support, but it seems it's not)

@doronbehar
Copy link
Contributor

This seems more like a issue with Irrlicht engine on aarch64 - see sourceforge.net/p/irrlicht/bugs/443 (irrlich thinks the system libpng was compiled with NEON instructions support, but it seems it's not)

Is irrlicht a bundled dependency built within the build of voxeland? Because from the log it seems it's voxeland's build that fails: https://logs.nix.ci/?key=nixos/nixpkgs.104705&attempt_id=ce623944-0fb0-4184-8afb-3211576e4a57

@prusnak
Copy link
Member Author

prusnak commented Nov 25, 2020

Is irrlicht a bundled dependency built within the build of voxeland?

No. If I see it correctly voxeland uses system irrlicht.

@doronbehar
Copy link
Contributor

Is irrlicht a bundled dependency built within the build of voxeland?

No. If I see it correctly voxeland uses system irrlicht.

Then if irrlicht was the failing build, the build log wouldn't have looked like this:

[ 99%] Linking CXX executable ../../bin/voxelands-server
[ 99%] Built target voxelands-server
[100%] Linking CXX executable ../../bin/voxelands
/nix/store/liq5wrz3yprc9623bb9lc90qv610gsd8-binutils-2.31.1/bin/ld: /nix/store/ci25cir0pkj8h2dmsaxppdcyqif2m0cb-irrlicht-1.8.4/lib/libIrrlicht.so: undefined reference to `png_init_filter_functions_neon'
collect2: error: ld returned 1 exit status
make[2]: *** [src/CMakeFiles/voxelands.dir/build.make:1370: ../bin/voxelands] Error 1
make[1]: *** [CMakeFiles/Makefile2:186: src/CMakeFiles/voxelands.dir/all] Error 2
make: *** [Makefile:171: all] Error 2
error: --- Error --- nix-build
error: --- Error --- nix-daemon
builder for '/nix/store/9lzw62zdgkzq8jb25xs9yq22ar793q81-voxelands-1704.00.drv' failed with exit code 2; last 10 log lines:
    414 |   for (u8 i = 0; i < 8; i++) {
        |   ^~~
  [ 99%] Linking CXX executable ../../bin/voxelands-server
  [ 99%] Built target voxelands-server
  [100%] Linking CXX executable ../../bin/voxelands
  /nix/store/liq5wrz3yprc9623bb9lc90qv610gsd8-binutils-2.31.1/bin/ld: /nix/store/ci25cir0pkj8h2dmsaxppdcyqif2m0cb-irrlicht-1.8.4/lib/libIrrlicht.so: undefined reference to `png_init_filter_functions_neon'
  collect2: error: ld returned 1 exit status

As you can see, it's voxelands' binaries that fail to link, not irrlicht's. Whatever the reason is, we should mark it as broken for aarch64, ideally with a comment saying the build expects neon symbols or something like that.

@prusnak
Copy link
Member Author

prusnak commented Nov 26, 2020

we should mark it as broken for aarch64

Addressed in 1ed49e3

@doronbehar doronbehar merged commit 2a84a49 into NixOS:master Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@doronbehar doronbehar doronbehar approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@prusnak @doronbehar @jonringer