-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ghc8102: bootstrap with ghc8102BinaryMinimal on aarch32 #104683
Conversation
I don‘t feel really to qualified to judge this PR, but maybe you could be slightly more verbose in your commit message? e.g. which ghc version does not evaluate? (I know that it is derivable from the context, but I think it would make it easier to see what's going on at a glimpse. Also "evaluate" in nix context normally means, that the nix code does not produce a valid nix-derivation. Is that what you mean? If yes could maybe give a link to what fails? Or is the problem building the derivation? |
hi @maralorn the issue is that i cannot build any packages on armv7 i always run into this error:
it should be noted that ghc does provide armv binaries |
I have no idea. otoh hand after some consideration activating a fix that is used for arm 64bit also for arm32bit seems very sane to me. Have you actually tested that this solves your problem? (Just a bit suspicious because your branch name looks like this change happened in github ui.) I have no way to test this and ofBorg does not seem to be a lot of help … |
@maralorn your suspicion is right i have a low end device so i haven't been able to test it yet, do you have any tips on how i should test it? i do have a setup using github actions that does reproduce the error without the 'fix' |
No, not really, sorry. I guess we'll need someone with a system like that, to jump in. I’ll try to ask around. |
I was able to do this on my Like you can just use I can re-test later to make sure it's still the case and that it works with This needs a more descriptive commit message tho, something like |
@Fuseteam You can run "git commit --amend" on the branch and then force push. |
alright will do |
welp i figured i would do it with a git clone but dang is it big 😂 only 25% and 300MB and counting 😂 |
ghc refuses to evaluate on armhf even tho ghc does provide binaries for the arch
I'll be honest, looking at the error again I'm growing skeptical if this will actually solve it........., for some reason the error message seems to refer to ghc 8.8.4, but if i'm reading this right i modified ghc-8.10.2 |
It depends on nixpkgs commit which you are using. A week ago
|
oh yeah lemme try the latest commit |
ah cool it changed the rev to newer version and indeed pulls the 8.10.2 thanks for the reassurance |
i have now verified with github actions that it no longer runs into the same issue with this change. the job obviously fails due to not actually being set up for cross compilation but that's outside the scope of this issue i think |
@sorki You said you also wanted to test run this. Can you can confirm, that it works for you, too? |
I've used similar approach like a month ago so it should be good. I'm unable to test this right now as I can't really update my system due to unrelated coreutils build failure. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thx |
awesome |
ghc refuses to evaluate on armhf even tho ghc does provide binaries for the arch
hi @sorki as discussed i have now proposed the change
Motivation for this change
compilation on armv7 fails because ghc fails to evaluate
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)