Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

shotcut: fix melt path #104677

Merged
merged 1 commit into from Nov 24, 2020
Merged

shotcut: fix melt path #104677

merged 1 commit into from Nov 24, 2020

Conversation

woffs
Copy link
Contributor

@woffs woffs commented Nov 23, 2020 •
edited

Motivation for this change

close #104666
to be backported to 20.09, too

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@SuperSandro2000
Copy link
Member

Can you rebase the branch on master? I think it solves the eval issue.

@woffs
Copy link
Contributor Author

woffs commented Nov 23, 2020

Can you rebase the branch on master? I think it solves the eval issue.

fingers crossed

@peti peti merged commit e49ba89 into NixOS:master Nov 24, 2020
@woffs woffs mentioned this pull request Nov 24, 2020
Merged
10 tasks
@evrim
Copy link
Contributor

evrim commented Nov 26, 2020

Im afraid this is still a problem on unstable.

@woffs
Copy link
Contributor Author

woffs commented Nov 26, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cillianderoiste cillianderoiste Awaiting requested review from cillianderoiste

@peti peti Awaiting requested review from peti

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Melt is missing in bin directory of Shotcut
4 participants
@woffs @SuperSandro2000 @evrim @peti