Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

recoll: refactor and 1.24.5 -> 1.27.12 #104699

Merged
merged 1 commit into from Nov 24, 2020
Merged

recoll: refactor and 1.24.5 -> 1.27.12 #104699

merged 1 commit into from Nov 24, 2020

Conversation

fabianhjr
Copy link
Member

@fabianhjr fabianhjr commented Nov 23, 2020 •
edited

Changes:

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@fabianhjr
recoll: refactor and 1.24.5 -> 1.27.12
3ec7527 
Refactor Changes:

- name -> pname + version
- python2 -> python3
- add pkg-config (to find libxslt)
- patch /usr/share/recoll to $out/share/recoll
- remove Makefile patch for macOS that has been merged upstream (
  https://framagit.org/medoc92/recoll/-/commit/b5c5734d064c638b702601fd391037a35b5bb2a1 )
@fabianhjr fabianhjr mentioned this pull request Nov 23, 2020
Closed
77 tasks
@ryantm
Copy link
Member

ryantm commented Nov 24, 2020

@jcumming , maintainer, for review and testing

@ryantm
Copy link
Member

ryantm commented Nov 24, 2020

Result of nixpkgs-review pr 104699 1

1 package built:
  • recoll

@jcumming
Copy link
Contributor

LGTM!

@ryantm ryantm merged commit d3de5b0 into NixOS:master Nov 24, 2020
@fabianhjr fabianhjr deleted the update-recoll branch November 24, 2020 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryantm ryantm ryantm left review comments

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@fabianhjr @ryantm @jcumming