Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

readme: update reference to number of packages #105413

Merged
merged 1 commit into from Nov 30, 2020
Merged

readme: update reference to number of packages #105413

merged 1 commit into from Nov 30, 2020

Conversation

ryantm
Copy link
Member

@ryantm ryantm commented Nov 30, 2020

We updated the top of the readme to reference 60,000, but we forgot to
update this reference. This changes it so it won't become invalid for
a bit.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @jonringer

@ryantm
readme: update reference to number of packages
82657dc 
We updated the top of the readme to reference 60,000, but we forgot to
update this reference. This changes it so it won't become invalid for
a bit.
@mweinelt mweinelt merged commit ec433df into NixOS:master Nov 30, 2020
@jonringer
Copy link
Contributor

oops, came to the party late

@ryantm ryantm deleted the updatereadme branch June 26, 2021 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ryantm @jonringer @mweinelt @SuperSandro2000