cpp_ethereum: remove #105421
Merged
cpp_ethereum: remove #105421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SuperSandro2000
requested changes
Nov 30, 2020
| @@ -41,6 +41,7 @@ mapAliases ({ | |||
| ag = silver-searcher; # added 2018-04-25 | |||
| aircrackng = aircrack-ng; # added 2016-01-14 | |||
| alienfx = throw "alienfx has been removed."; # added 2019-12-08 | |||
| aleth = throw "aleth (previously packaged as cpp_ethereum) has been removed; abandoned upstream."; # added 2020-11-30 | |||
There was a problem hiding this comment.
Why are you adding this? This package was never in nixpkgs.
There was a problem hiding this comment.
cpp-ethereum was renamed to aleth quite a while back, we just never renamed it on our end - If someone comes looking for it now, they will likely be looking for aleth
| @@ -92,6 +93,7 @@ mapAliases ({ | |||
| coprthr = throw "coprthr has been removed."; # added 2019-12-08 | |||
| corebird = throw "corebird was deprecated 2019-10-02: See https://www.patreon.com/posts/corebirds-future-18921328. Please use Cawbird as replacement."; | |||
| coredumper = throw "coredumper has been removed: abandoned by upstream."; # added 2019-11-16 | |||
| cpp_ethereum = throw "cpp_ethereum has been removed; abandoned upstream."; # added 2020-11-30 | |||
There was a problem hiding this comment.
Suggested change
| cpp_ethereum = throw "cpp_ethereum has been removed; abandoned upstream."; # added 2020-11-30 | |
| cpp_ethereum = throw "cpp_ethereum has been removed because upstream abandoned it and it is broken with current version of ethereum chain."; # added 2020-11-30 |
There was a problem hiding this comment.
It is not strictly broken yet - but likely will be by the time 21.03 is released once the staking updates for Ethereum go live next month
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
#103890
cpp-ethereum was renamed to aleth upstream
aleth was subsequently abandoned upstream (https://gitter.im/ethereum/aleth?at=5e7cb22c2520175199ead0ba)
It is not currently used by anything in nixpkgs, and is fairly useless for actual ethereum development given that it has not kept up with recent changes to the ethereum network
cpp_ethereum was also the only package using libjson-rpc-cpp. However, I am not removing that as it needs to be updated (#98072) and I am working on packaging Zilliqa, which also relies on libjson-rpc-cpp.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)