Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thunderbird, thunderbird-bin: 78.4.3 -> 78.5.0 [High security fixes] #104378

Merged
merged 2 commits into from Nov 21, 2020

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Nov 20, 2020

Motivation for this change
  • High security fixes
  • Other changes and fixes

https://www.thunderbird.net/en-US/thunderbird/78.5.0/releasenotes/
https://www.mozilla.org/en-US/security/advisories/mfsa2020-52/

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@mohe2015 mohe2015 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested both and they still seem to work. I would vote for merging this soon as these are security fixes.

Copy link
Member

@lovesegfault lovesegfault left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's get this in ASAP cc. @vcunat @andir

@andir
Copy link
Member

andir commented Nov 20, 2020

Can you provide the stable versions as well?

Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both seem to work for me; risk of regressions is probably relatively low anyway.

@taku0
Copy link
Contributor Author

taku0 commented Nov 21, 2020

Created PR for 20.09: #104480. Do we need one for 20.03?

@vcunat
Copy link
Member

vcunat commented Nov 21, 2020

20.03 has official promise of support for another week, but reality is that with thunderbird releasing so often I've been neglecting 20.03 recently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants