Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

directx-shader-compiler: init at 1.5.2010 #104377

Merged
merged 1 commit into from Dec 19, 2020
Merged

directx-shader-compiler: init at 1.5.2010 #104377

merged 1 commit into from Dec 19, 2020

Conversation

expipiplus1
Copy link
Contributor

I've tested the compiler with some basic shaders and they seem to work
fine.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@expipiplus1
Copy link
Contributor Author

Thank you for the all the thoughtful feedback :D

@SuperSandro2000
Copy link
Member

@ofborg eval

@expipiplus1 Can you please rebase this branch on master?

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104377 run on x86_64-linux 1

1 package built:
  • directx-shader-compiler

@expipiplus1
Copy link
Contributor Author

@expipiplus1 Can you please rebase this branch on master?

done

@expipiplus1
Copy link
Contributor Author

Is it possible to merge this please?

Flakebi
Flakebi approved these changes Dec 16, 2020
View reviewed changes
Copy link
Member

@Flakebi Flakebi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks

Result of nixpkgs-review pr 104377 run on x86_64-linux 1

1 package built:
  • directx-shader-compiler

@expipiplus1
Copy link
Contributor Author

Hi, this has been open for a month now. Please can it be merged?

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-already-reviewed/2617/299

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104377 run on x86_64-darwin 1

1 package failed to build:
  • directx-shader-compiler
[ 98%] Building CXX object tools/clang/unittests/SPIRV/CMakeFiles/clang-spirv-tests.dir/WholeFileTestFixture.cpp.o
[100%] Building CXX object tools/clang/unittests/SPIRV/CMakeFiles/clang-spirv-tests.dir/TestMain.cpp.o
[100%] Building CXX object tools/clang/unittests/SPIRV/CMakeFiles/clang-spirv-tests.dir/StringTest.cpp.o
[100%] Linking CXX executable ../../../../bin/clang-spirv-tests
[100%] Built target clang-spirv-tests
@nix { "action": "setPhase", "phase": "installPhase" }
installing
mv: missing destination file operand after '/nix/store/52ah4dqh4iaacbxkj0l0ngrccyq22ckz-directx-shader-compiler-1.5.2010/lib/'
Try 'mv --help' for more information.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104377 run on x86_64-linux 1

1 package built:
  • directx-shader-compiler

@expipiplus1
Copy link
Contributor Author

I have limited the platforms to Linux only for now to get this merged. Will open a separate PR adding Darwin support pending someone with a mac testing.

@expipiplus1 expipiplus1 mentioned this pull request Dec 19, 2020
Merged
10 tasks
@SuperSandro2000 SuperSandro2000 merged commit 453c116 into NixOS:master Dec 19, 2020
@expipiplus1 expipiplus1 deleted the joe-dxc branch December 19, 2020 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sikmir sikmir sikmir left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@Flakebi Flakebi Flakebi approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@expipiplus1 @SuperSandro2000 @nixos-discourse @sikmir @Flakebi