Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update interfaces/web-nfc.idl and test #26590

Merged
merged 1 commit into from Nov 23, 2020
Merged

Update interfaces/web-nfc.idl and test #26590

merged 1 commit into from Nov 23, 2020

Conversation

stephenmcgruer
Copy link
Contributor

Closes #26589

@stephenmcgruer stephenmcgruer assigned foolip and unassigned kenchris Nov 20, 2020
@wpt-pr-bot wpt-pr-bot requested a deployment to wpt-preview-26590 November 20, 2020 13:00 Pending
@beaufortfrancois
Copy link
Contributor

The error doesn't seem related to the WPT.

requests.exceptions.ConnectionError: HTTPSConnectionPool(host='wptpr.live', port=443): Max retries exceeded with url: /.git/worktrees/26590/HEAD (Caused by NewConnectionError('<urllib3.connection.HTTPSConnection object at 0x7f5ed3b4a050>: Failed to establish a new connection: [Errno 111] Connection refused',))

I'd love to merge though as https://chromium-review.googlesource.com/c/chromium/src/+/2424208 depends on this PR.

beaufortfrancois
beaufortfrancois approved these changes Nov 23, 2020
View reviewed changes
Copy link
Contributor

@beaufortfrancois beaufortfrancois left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@beaufortfrancois beaufortfrancois merged commit fa16685 into master Nov 23, 2020
@beaufortfrancois beaufortfrancois deleted the smcgruer/web-nfx-idlharness branch November 23, 2020 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beaufortfrancois beaufortfrancois beaufortfrancois approved these changes

@foolip foolip Awaiting requested review from foolip

@Honry Honry Awaiting requested review from Honry

@kenchris kenchris Awaiting requested review from kenchris

Assignees

@foolip foolip

Labels
interfaces web-nfc
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@stephenmcgruer @beaufortfrancois @foolip @kenchris @wpt-pr-bot