Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

octant: 0.16.0 -> 0.16.2 -> 0.16.3 #104371

Merged
merged 2 commits into from Dec 11, 2020
Merged

octant: 0.16.0 -> 0.16.2 -> 0.16.3 #104371

merged 2 commits into from Dec 11, 2020

Conversation

06kellyjac
Copy link
Member

@06kellyjac 06kellyjac commented Nov 20, 2020 •
edited

Motivation for this change

Bump octant to 0.16.2 0.16.3

Still trying to get a source build

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS (x86_64)
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@06kellyjac
Copy link
Member Author

Result of nixpkgs-review pr 104371 1

1 package built:
  • octant

@SuperSandro2000
Copy link
Member

Can you rebase and force push the branch to give ofborg a nudge?

@06kellyjac
Copy link
Member Author

sure

@06kellyjac 06kellyjac mentioned this pull request Nov 23, 2020
Merged
10 tasks
@06kellyjac
Copy link
Member Author

Result of nixpkgs-review pr 104371 1

1 package built:
  • octant

@06kellyjac
Copy link
Member Author

Result of nixpkgs-review pr 104371 run on x86_64-linux 1

1 package built:
  • octant

@06kellyjac 06kellyjac changed the title octant: 0.16.0 -> 0.16.2 octant: 0.16.0 -> 0.16.2 -> 0.16.3 Dec 10, 2020
@06kellyjac
Copy link
Member Author

Result of nixpkgs-review pr 104371 run on x86_64-linux 1

1 package built:
  • octant

1 similar comment
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104371 run on x86_64-linux 1

1 package built:
  • octant

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 104371 run on x86_64-darwin 1

1 package built:
  • octant

@SuperSandro2000 SuperSandro2000 merged commit 6fc24a9 into NixOS:master Dec 11, 2020
@06kellyjac 06kellyjac deleted the octant branch December 11, 2020 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@06kellyjac @SuperSandro2000