Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

aws-sam-cli: 1.6.2 -> 1.11.0 #104383

Closed
wants to merge 2 commits into from
Closed

aws-sam-cli: 1.6.2 -> 1.11.0 #104383

wants to merge 2 commits into from

Conversation

pltanton
Copy link
Contributor

@pltanton pltanton commented Nov 20, 2020 •
edited

Motivation of change: current version is really outdated, many features
missed. In my case there was lack of HttpApi support for
sam local-run-api.

Also aws-sam-translator: 1.27.0 -> 1.30.1 as dependency.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from lo1tuma November 20, 2020 13:57
jonringer
jonringer reviewed Nov 20, 2020
View reviewed changes
pkgs/development/python-modules/aws-sam-translator/default.nix
Comment on lines +13 to +17
version = "1.30.1";

src = fetchPypi {
inherit pname version;
sha256 = "0m24cdiry8p74s5ysyriy6wks4ic8782sf21q4yvlwfn9hpi4n1j";
sha256 = "0d9ppd94x2kw404m49ajswmmxgdngbs4p5ajyrdvnlivfzqbv7dx";
Copy link
Contributor

@jonringer jonringer Nov 20, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should be a separate commit

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. Done.

@pltanton
aws-sam-translator: 1.27.0 -> 1.30.1
65c41ff
@pltanton
aws-sam-cli: 1.6.2 -> 1.11.0
80e40dd 
Motivation of change: current version is really outdated, many features
missed. In my case there was lack of HttpApi support for
`sam local-run-api`.
@pltanton
Copy link
Contributor Author

What about this PR? Can anyone review it?

@pltanton
Copy link
Contributor Author

@jonringer have I got any chance to merge it to upstream? :)

I hope it didn't sound rude (due to lack of my knowledge of English). But I can't find a recommended workflow for maintaining PRs for nixpkgs repository. Should I ping package maintainers or just wait for a several moth being sure, that it will be approved or declined someday?

@teto
Copy link
Member

teto commented Dec 13, 2020

seems we have a newer version #104782

@pltanton
Copy link
Contributor Author

Thanks, @teto. Closing this one then.

@pltanton pltanton closed this Dec 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@lo1tuma lo1tuma Awaiting requested review from lo1tuma

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 101-500 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pltanton @teto @jonringer