Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

musl: patch CVE-2020-28928 #104385

Merged
merged 1 commit into from Nov 30, 2020
Merged

musl: patch CVE-2020-28928 #104385

merged 1 commit into from Nov 30, 2020

Conversation

mweinelt
Copy link
Member

Motivation for this change

https://www.openwall.com/lists/oss-security/2020/11/20/4

Destination buffer overflow in wcsnrtombs.

Fixes: CVE-2020-28928

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt mweinelt added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Nov 20, 2020
@mweinelt
musl: patch CVE-2020-28928
138abad 
Destination buffer overflow in wcsnrtombs.

Fixes: CVE-2020-28928
@RaghavSood
Copy link
Member

Result of nixpkgs-review pr 104385 1

4 packages failed to build:
  • fusionInventory
  • hercules-ci-agent
  • nix-exec
  • python37Packages.nixpkgs
53 packages built:
  • bundix
  • busybox-sandbox-shell
  • cabal2nix
  • cachix
  • common-updater-scripts
  • crate2nix
  • crystal2nix
  • dep2nix
  • disnix
  • disnixos
  • go2nix
  • hydra-unstable
  • lispPackages.quicklisp-to-nix
  • lispPackages.quicklisp-to-nix-system-info
  • musl
  • nix (nixStable)
  • nix-binary-cache
  • nix-bundle
  • nix-direnv
  • nix-doc
  • nix-du
  • nix-index
  • nix-pin
  • nix-plugins
  • nix-prefetch
  • nix-prefetch-bzr
  • nix-prefetch-cvs
  • nix-prefetch-docker
  • nix-prefetch-git
  • nix-prefetch-hg
  • nix-prefetch-scripts
  • nix-prefetch-svn
  • nix-review (nixpkgs-review)
  • nix-serve
  • nix-update
  • nix-update-source
  • nixFlakes (nixUnstable)
  • nixos-generators
  • nixos-shell
  • nixui
  • python37Packages.nassl
  • python37Packages.nix-kernel
  • python37Packages.pythonix
  • python37Packages.sslyze
  • python38Packages.nassl
  • python38Packages.nix-kernel
  • python38Packages.nixpkgs
  • python38Packages.pythonix
  • sslyze (python38Packages.sslyze)
  • update-nix-fetchgit
  • vgo2nix
  • vscode-extensions.ms-python.python
  • vulnix

@andir andir self-assigned this Nov 30, 2020
@lukegb
Copy link
Contributor

lukegb commented Nov 30, 2020

@ofborg build pkgsMusl.nix pkgsMusl.bash pkgsMusl.zsh

@lukegb
Copy link
Contributor

lukegb commented Nov 30, 2020

@ofborg eval

@andir andir merged commit 13481f2 into NixOS:master Nov 30, 2020
@mweinelt mweinelt deleted the musl branch November 30, 2020 15:40
@mweinelt mweinelt mentioned this pull request Nov 30, 2020
Merged
10 tasks
@mweinelt mweinelt removed the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikanezrimaya vikanezrimaya vikanezrimaya approved these changes

@dtzWill dtzWill Awaiting requested review from dtzWill

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees

@andir andir

Labels
1.severity: security 10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@mweinelt @RaghavSood @lukegb @vikanezrimaya @andir