Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

haskellPackages.hakyll: make buildable by Hydra #104375

Merged
merged 1 commit into from Nov 20, 2020
Merged

haskellPackages.hakyll: make buildable by Hydra #104375

merged 1 commit into from Nov 20, 2020

Conversation

vaibhavsagar
Copy link
Member

@vaibhavsagar vaibhavsagar commented Nov 20, 2020 •
edited

Motivation for this change

#104273 (comment)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vaibhavsagar vaibhavsagar mentioned this pull request Nov 20, 2020
Merged
10 tasks
@maralorn maralorn merged commit 6fb5786 into NixOS:release-20.09 Nov 20, 2020
@vaibhavsagar
Copy link
Member Author

Thanks!

@vaibhavsagar vaibhavsagar deleted the build-hakyll branch November 20, 2020 15:08
@ghost
Copy link

ghost commented Nov 25, 2020

/* hackage-packages.nix is an auto-generated file -- DO NOT EDIT! */

You should remove it from pkgs/development/haskell-modules/configuration-hackage2nix.yaml see #73755

@cdepillabout
Copy link
Member

@gnidorah Hey, sorry for the confusion here.

The pkgs/development/haskell-modules/hackage-packages.nix file is automatically generated using the settings in pkgs/development/haskell-modules/configuration-hackage2nix.yaml on the haskell-updates branch (and then merged into master).

However, after we split off a release, we no longer automatically regenerate/update the pkgs/development/haskell-modules/hackage-packages.nix file, so it is necessary to edit it directly. This only applies for the release branches though.

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/new-ghc-default-version-8-10-2-package-versions-now-from-stackage-nightly/10117/31

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout cdepillabout is a code owner

Assignees
No one assigned
Labels
6.topic: haskell 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@vaibhavsagar @cdepillabout @nixos-discourse @maralorn