Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Gnome 3.38 fixes #103142

Merged
merged 2 commits into from Nov 8, 2020
Merged

Gnome 3.38 fixes #103142

merged 2 commits into from Nov 8, 2020

Conversation

hedning
Copy link
Contributor

@hedning hedning commented Nov 8, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@hedning hedning changed the title Gnome fixes Gnome 3.38 fixes Nov 8, 2020
@ofborg ofborg bot added the 6.topic: GNOME GNOME desktop environment and its underlying platform label Nov 8, 2020
@ofborg ofborg bot requested review from worldofpeace and jtojnar November 8, 2020 15:56
@hedning
gnome3.mutter: use full sysprof
752773e 
Mutter needs acces to sysprofs dbus interfaces at build time, which the
libsysprof-capture package fail to provide.

Also fix libdir name.
@hedning
gnome3.gnome-tweaks: use libhandy_0
9aa5a10
@ofborg ofborg bot requested a review from jtojnar November 8, 2020 19:05
@hedning hedning merged commit 2df2c6b into NixOS:staging-next Nov 8, 2020
@hedning hedning deleted the gnome-fixes branch November 8, 2020 19:27
andersk added a commit to andersk/nixpkgs that referenced this pull request Nov 11, 2020
@andersk
gnome3.mutter334: Use full sysprof
49bd665 
Commit 56b9441 (NixOS#101528) incorrectly
switched mutter and mutter334 from full sysprof to libsysprof-capture,
causing channel-blocking build failures:

https://hydra.nixos.org/build/129977355 (mutter)
https://hydra.nixos.org/build/130019098 (mutter334)

Commit 752773e (NixOS#103142) reverted only
the mutter part.  This reverts the mutter334 part.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@andersk andersk mentioned this pull request Nov 11, 2020
Merged
10 tasks
@andersk
Copy link
Contributor

andersk commented Nov 11, 2020

mutter334 needs the same revert: #103400

@andersk andersk mentioned this pull request Nov 11, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

@jtojnar jtojnar Awaiting requested review from jtojnar

Assignees
No one assigned
Labels
6.topic: GNOME GNOME desktop environment and its underlying platform 10.rebuild-darwin: 0 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hedning @andersk @jtojnar