Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3.pkgs.bme680: init at 1.0.5 #103119

Merged
merged 3 commits into from Nov 8, 2020
Merged

python3.pkgs.bme680: init at 1.0.5 #103119

merged 3 commits into from Nov 8, 2020

Conversation

Mic92
Copy link
Member

@Mic92 Mic92 commented Nov 8, 2020 •
edited

Motivation for this change

home-assistant + bme680-mqtt

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 changed the title Bme680 python3.pkgs.bme680: init at 1.0.5 Nov 8, 2020
@Mic92 Mic92 requested a review from mweinelt November 8, 2020 09:54
mweinelt
mweinelt reviewed Nov 8, 2020
View reviewed changes
Copy link
Member

@mweinelt mweinelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, but please squash the fixup commits.

@mweinelt mweinelt merged commit 9fba50b into NixOS:master Nov 8, 2020
@Mic92 Mic92 deleted the bme680 branch November 8, 2020 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@lukegb lukegb lukegb requested changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Mic92 @mweinelt @lukegb @SuperSandro2000