Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linuxPackages.ndiswrapper: 1.62-pre -> 1.63 #103124

Merged
merged 1 commit into from Nov 18, 2020
Merged

linuxPackages.ndiswrapper: 1.62-pre -> 1.63 #103124

merged 1 commit into from Nov 18, 2020

Conversation

KamilaBorowska
Copy link
Member

Motivation for this change

Fixing the build.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@KamilaBorowska
Copy link
Member Author

/marvin opt-in
/status needs_reviewer

@ofborg build linuxPackages_4_4.ndiswrapper linuxPackages_4_9.ndiswrapper linuxPackages_4_14.ndiswrapper linuxPackages_4_19.ndiswrapper linuxPackages_5_4.ndiswrapper

@marvin-mk2 marvin-mk2 bot added the marvin label Nov 8, 2020
@marvin-mk2
Copy link

marvin-mk2 bot commented Nov 8, 2020

Hi! I'm an experimental bot. My goal is to guide this PR through its stages, hopefully ending with a merge. You can read up on the usage here.

delroth
delroth approved these changes Nov 17, 2020
View reviewed changes
Copy link
Contributor

@delroth delroth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/status needs_merger

@marvin-mk2 marvin-mk2 bot requested a review from timokau November 17, 2020 02:37
@KamilaBorowska
Copy link
Member Author

@ofborg build linuxPackages_4_4.ndiswrapper linuxPackages_4_9.ndiswrapper linuxPackages_4_14.ndiswrapper linuxPackages_4_19.ndiswrapper linuxPackages_5_4.ndiswrapper

@KamilaBorowska
Copy link
Member Author

@ofborg build linuxPackages_4_4.ndiswrapper linuxPackages_4_9.ndiswrapper linuxPackages_4_14.ndiswrapper linuxPackages_4_19.ndiswrapper linuxPackages_5_4.ndiswrapper

@KamilaBorowska
Copy link
Member Author

@ofborg build linuxPackages_4_4.ndiswrapper linuxPackages_4_9.ndiswrapper linuxPackages_4_14.ndiswrapper linuxPackages_4_19.ndiswrapper linuxPackages_5_4.ndiswrapper

timokau
timokau approved these changes Nov 18, 2020
View reviewed changes
Copy link
Member

@timokau timokau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@timokau timokau merged commit 9140b11 into NixOS:master Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@delroth delroth delroth approved these changes

@timokau timokau timokau approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100 awaiting_reviewer marvin
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KamilaBorowska @delroth @timokau