Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wlroots: 0.11.0 -> 0.12.0 #103145

Merged
merged 2 commits into from Nov 8, 2020
Merged

wlroots: 0.11.0 -> 0.12.0 #103145

merged 2 commits into from Nov 8, 2020

Conversation

primeos
Copy link
Member

@primeos primeos commented Nov 8, 2020

Motivation for this change

WIP, need to wait for updates of the reverse dependencies first or patch them:

  • sway-unwrapped/sway (-> sway-contrib.grimshot and waybar)

nixpkgs-review:

10 packages built:
cage cagebreak fuzzel hikari qt-video-wlr sway sway-contrib.grimshot sway-unwrapped waybar wlroots
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

The libseat session backend [0] will be disabled for now since NixOS
depends on systemd anyway (so we can use logind).
But if someone wants/requires libseat [1] and would maintain it in
Nixpkgs we could enable it.

[0]: swaywm/wlroots#2364
[1]: https://sr.ht/~kennylevinsen/seatd/
Sway 1.5 isn't affected by the breaking changes of wlroots 0.12.0 so we
can simply relax the version requirement.
@primeos
Copy link
Member Author

primeos commented Nov 8, 2020

@GrahamcOfBorg test cage cagebreak

@primeos primeos marked this pull request as ready for review November 8, 2020 21:45
@primeos primeos merged commit 420daef into NixOS:master Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant