Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libexif: apply patches for CVE-2020-0196, CVE-2020-0452 #103144

Merged
merged 1 commit into from Nov 8, 2020
Merged

libexif: apply patches for CVE-2020-0196, CVE-2020-0452 #103144

merged 1 commit into from Nov 8, 2020

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Nov 8, 2020

Motivation for this change

Had to rebase the commits, because they don't cleanly apply without picking other stuff, so I added them as patches to the repo.

  • CVE-2020-0198: unsigned integer overflow in exif_data_load_data_content
  • CVE-2020-0452: compiler optimization could remove an a bufferoverflow check, making a buffer overflow possible with some EXIF tags

Fixes: CVE-2020-0196, CVE-2020-0452

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mweinelt mweinelt added 1.severity: security 9.needs: port to stable A PR needs a backport to the stable release. labels Nov 8, 2020
@ofborg ofborg bot requested a review from erictapen November 8, 2020 15:56
erictapen
erictapen requested changes Nov 8, 2020
View reviewed changes
Copy link
Member

@erictapen erictapen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

pkgs/development/libraries/libexif/default.nix Outdated Show resolved Hide resolved
pkgs/development/libraries/libexif/default.nix Show resolved Hide resolved
@ofborg ofborg bot requested a review from erictapen November 8, 2020 17:54
erictapen
erictapen reviewed Nov 8, 2020
View reviewed changes
pkgs/development/libraries/libexif/default.nix Outdated
(fetchpatch {
name = "CVE-2020-0198.patch";
url = "https://github.com/libexif/libexif/commit/ce03ad7ef4e8aeefce79192bf5b6f69fae396f0c.patch";
sha256 = "0cy3kspggysmj7y15m2klsbq7zw3ir3bb1sw6bv4prnx2c5mb667";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Both sha256 are wrong for me?

Copy link
Member Author

@mweinelt mweinelt Nov 8, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Must be caching. sigh

Will fix after dinner asap.

@mweinelt
libexif: apply patches for CVE-2020-0196, CVE-2020-0452
52cf908 
* CVE-2020-0198: unsigned integer overflow in exif_data_load_data_content
* CVE-2020-0452: compiler optimization could remove an a bufferoverflow check, making a buffer overflow possible with some EXIF tags

Fixes: CVE-2020-0196, CVE-2020-0452
@ofborg ofborg bot requested a review from erictapen November 8, 2020 18:54
erictapen
erictapen approved these changes Nov 8, 2020
View reviewed changes
Copy link
Member

@erictapen erictapen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you.

@erictapen erictapen merged commit 602d26e into NixOS:master Nov 8, 2020
@mweinelt mweinelt deleted the libexif branch November 8, 2020 20:54
This was referenced Nov 8, 2020
Merged
Merged
@mweinelt mweinelt removed the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erictapen erictapen erictapen approved these changes

Assignees
No one assigned
Labels
1.severity: security 10.rebuild-darwin: 101-500 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mweinelt @erictapen