Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.09] libexif: apply patches for CVE-2020-0198, CVE-2020-0452 #103165

Merged
merged 1 commit into from Nov 8, 2020

Conversation

mweinelt
Copy link
Member

@mweinelt mweinelt commented Nov 8, 2020

Motivation for this change

Backport #103144 with correct CVE-IDs.

  • CVE-2020-0198: unsigned integer overflow in exif_data_load_data_content
  • CVE-2020-0452: compiler optimization could remove an a bufferoverflow check, making a buffer overflow possible with some EXIF tags

Fixes: CVE-2020-0198, CVE-2020-0452
(cherry picked from commit 602d26e)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

* CVE-2020-0198: unsigned integer overflow in exif_data_load_data_content
* CVE-2020-0452: compiler optimization could remove an a bufferoverflow check, making a buffer overflow possible with some EXIF tags

Fixes: CVE-2020-0198, CVE-2020-0452
(cherry picked from commit 602d26e)
@mweinelt mweinelt changed the title libexif: apply patches for CVE-2020-0198, CVE-2020-0452 [20.09] libexif: apply patches for CVE-2020-0198, CVE-2020-0452 Nov 8, 2020
Copy link
Member

@erictapen erictapen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right, was just about to backport it ;)
Builds for me.

@erictapen erictapen merged commit d12178b into NixOS:release-20.09 Nov 8, 2020
@ofborg ofborg bot requested a review from erictapen November 8, 2020 21:09
@mweinelt mweinelt deleted the 20.09/libexif branch November 8, 2020 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants