Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.ocaml-lsp: init at 1.1.0 #103133

Closed
wants to merge 1 commit into from
Closed

ocamlPackages.ocaml-lsp: init at 1.1.0 #103133

wants to merge 1 commit into from

Conversation

symphorien
Copy link
Member

Motivation for this change

I've been using it for a week and the quicker feedback on errors is nice to have, imo.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vbgl
Copy link
Contributor

vbgl commented Nov 8, 2020

Merged as b393908

@vbgl vbgl closed this Nov 8, 2020
@vbgl vbgl mentioned this pull request Nov 8, 2020
Closed
10 tasks
@vbgl
Copy link
Contributor

vbgl commented Nov 8, 2020

Merged into 20.09 as bc45fa3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: ocaml 8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@symphorien @vbgl