Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.urwidtrees: 1.0.2 -> 1.0.3 #103149

Merged
merged 1 commit into from Nov 12, 2020
Merged

pythonPackages.urwidtrees: 1.0.2 -> 1.0.3 #103149

merged 1 commit into from Nov 12, 2020

Conversation

teto
Copy link
Member

@teto teto commented Nov 8, 2020

Motivation for this change

trying to compile alot master and it requires a newer version

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@teto
Copy link
Member Author

teto commented Nov 8, 2020

it doesn't pass nixpkgs-review here, don't merge

@jonringer
Copy link
Contributor

mock really shouldn't be getting propagated though.

could just apply pazz/urwidtrees@ed39dbc and remove mock from the expression, altogether

@teto
Copy link
Member Author

teto commented Nov 11, 2020

done

@teto teto merged commit 6818de3 into NixOS:master Nov 12, 2020
@teto teto deleted the urwidtrees branch November 12, 2020 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants