Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jdk8: fix hashes & include script to generate them #103171

Closed
wants to merge 1 commit into from
Closed

jdk8: fix hashes & include script to generate them #103171

wants to merge 1 commit into from

Conversation

basvandijk
Copy link
Member

Motivation for this change

As discussed in this thread on discourse the hashes of openjdk8 changed. This commit fixes them and includes a script to generate them.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@basvandijk
Copy link
Member Author

@GrahamcOfBorg build jdk8 jre8

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/hash-mismatch-building-jre-on-release-20-09/9898/5

@ofborg ofborg bot requested a review from edwtjo November 8, 2020 21:43
@basvandijk
Copy link
Member Author

Unfortunately the tarballs returned from https://hg.openjdk.java.net change all the time so these hashes are not stable. We need to find a source that returns stable tarballs.

@basvandijk basvandijk closed this Nov 15, 2020
@phile314 phile314 mentioned this pull request Dec 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edwtjo edwtjo Awaiting requested review from edwtjo

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@basvandijk @nixos-discourse