Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roundcube service: Restart on config changes #103170

Merged
merged 1 commit into from Nov 9, 2020

Conversation

nh2
Copy link
Contributor

@nh2 nh2 commented Nov 8, 2020

Motivation for this change

Until now, e.g. extraConfig changes did not reflect in the system on nixos-rebuild switch.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

I've tested the equivalent of this on my 20.09 system's config:

  systemd.services."phpfpm-roundcube".restartTriggers = [ config.environment.etc."roundcube/config.inc.php".source ];

CC roundcube maintainers: @Vskilet @globin @Ma27

Until now, e.g. `extraConfig` changes did not reflect in
the system on `nixos-rebuild switch`.
@Ma27 Ma27 merged commit e74d673 into NixOS:master Nov 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants