libjxl: init at 2021-06-22-409efe02 (jpeg-xl reference implementation) #103160

nh2 · 2020-11-08T19:51:32Z

Motivation for this change

Packages the JPEG XL reference implementation: jpeg-xl.

I start this as a draft PR because:

need to fix that their git submodule setup is currently broken (https://gitlab.com/wg1/jpeg-xl/-/issues/57), so src is from my fork.
I'm not sure I want to be maintainer for it, would be nice if somebody else would step up.

Also I'm PRing it against 20.09 to make it easy to test, of course it'll have to be rebased against master for the final PR.

Things done

nixos-discourse · 2020-11-08T19:54:06Z

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/packages-looking-for-a-maintainer/5442/5

pkgs/development/libraries/jpeg-xl/default.nix

SuperSandro2000 · 2020-11-08T22:14:58Z

pkgs/development/libraries/jpeg-xl/default.nix

+  cmakeFlags = [
+  ];


Is this meant to be empty?

I kept it empty for now just to make clear to whoever would like to step up for maintenance that this is a cmake bulid and that this is where options would go.

We might for example be interested in these: https://gitlab.com/wg1/jpeg-xl/-/blob/4d70bd58fbcb758b61446aba447fedd9177a00c9/CMakeLists.txt#L98-104

set(JPEGXL_FORCE_SYSTEM_GTEST false CACHE BOOL "Force using system installed googletest (gtest/gmock) instead of third_party/googletest source.") set(JPEGXL_FORCE_SYSTEM_BROTLI false CACHE BOOL "Force using system installed brotli instead of third_party/brotli source.") set(JPEGXL_FORCE_SYSTEM_HWY false CACHE BOOL "Force using system installed highway (libhwy-dev) instead of third_party/highway source.")

if we want it to use our system libs (but I'm also OK with it using its submodule libs, as I'm not sure if jpeg-xl often patches them).

~~If we find we need to cmakeFlags, we can of course remove that empty list.~~ I've removed it now, we can add it back when needed.

I think we should use system libs if they are available or add a comment to use them in the future except if they are heavily patched.

Fine by me, but then we first need to have a good look into whether they changed important stuff or not.

I've added a comment.

pkgs/development/libraries/jpeg-xl/default.nix

SuperSandro2000 · 2020-11-11T09:03:06Z

Result of nixpkgs-review pr 103160 run on x86_64-darwin 1

1 package failed to build:

jpeg-xl

/tmp/nix-build-jpeg-xl-2020-10-29-8f2e0857.drv-0/jpeg-xl-8f2e085/lib/extras/codec_apng.cc:222:13: error: use of undeclared identifier 'fmemopen'; did you mean 'freopen'?
  if (!(f = fmemopen((void*)bytes.data(), bytes.size(), "rb"))) {
            ^~~~~~~~
            freopen
/nix/store/h144jawqa92rqjhaahrsikq5j2dwkh5n-Libsystem-osx-10.12.6/include/stdio.h:248:7: note: 'freopen' declared here
FILE    *freopen(const char * __restrict, const char * __restrict,
         ^
/tmp/nix-build-jpeg-xl-2020-10-29-8f2e0857.drv-0/jpeg-xl-8f2e085/lib/extras/codec_apng.cc:222:22: error: cannot initialize a parameter of type 'const char *' with an rvalue of type 'void *'
  if (!(f = fmemopen((void*)bytes.data(), bytes.size(), "rb"))) {
                     ^~~~~~~~~~~~~~~~~~~
/nix/store/h144jawqa92rqjhaahrsikq5j2dwkh5n-Libsystem-osx-10.12.6/include/stdio.h:248:38: note: passing argument to parameter here
FILE    *freopen(const char * __restrict, const char * __restrict,
                                        ^
2 errors generated.
make[2]: *** [lib/CMakeFiles/jxl_extras-static.dir/build.make:160: lib/CMakeFiles/jxl_extras-static.dir/extras/codec_apng.cc.o] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [CMakeFiles/Makefile2:1180: lib/CMakeFiles/jxl_extras-static.dir/all] Error 2
make: *** [Makefile:160: all] Error 2

SuperSandro2000 · 2020-11-26T01:51:20Z

Result of nixpkgs-review pr 103160 run on x86_64-linux 1

1 package failed to build:

jpeg-xl

hash mismatch in fixed-output derivation '/nix/store/05w2idsr1j896cjaxnd2hwiwk1sfq3hb-jpeg-xl-131953a':
  wanted: sha256:09vp73wqrhflv26xbikcpiw2bb37ffgc3skggpwycdcswn919m85
  got:    sha256:10xaqnmw48sz274m1gf2762xpy0sd453mmh10j8j432wx14y2pss
cannot build derivation '/nix/store/mrwwq6vfk4kikw7z8yjqx7zmrjj49a5j-jpeg-xl-2020-11-10-131953af.drv': 1 dependencies couldn't be built
cannot build derivation '/nix/store/ama94bv01n0bh6fdk1a4l7ls6y5j3phj-env.drv': 1 dependencies couldn't be built

stale · 2021-06-03T20:34:40Z

I marked this as stale due to inactivity. → More info

nh2 · 2021-06-22T16:46:20Z

Hmm, I just updated this, but now noticed that they moved from Gitlab to Github and renamed the project from jpeg-xl to libjxl:

https://gitlab.com/wg1/jpeg-xl/-/issues/245

nh2 · 2021-06-22T18:10:35Z

ofborg says

@ofborg ofborg-eval — Complete, with errors

But it doesn't seem to post where I can read those errors.

pkgs/development/libraries/libjxl/default.nix

nh2 · 2021-06-22T18:23:38Z

@ofborg ofborg-eval — Complete, with errors

But it doesn't seem to post where I can read those errors.

Apparently I had to look at the sibling github check ofborg-eval-package-list-no-aliases, which was failed, and contained:

warning: ignoring the user-specified setting 'restrict-eval', because it is a restricted setting and you are not a trusted user
error: while evaluating 'callPackageWith' at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/ofborg-evaluator-2/lib/customisation.nix:117:35, called from /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/ofborg-evaluator-2/pkgs/top-level/all-packages.nix:16622:12:
while evaluating 'makeOverridable' at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/ofborg-evaluator-2/lib/customisation.nix:67:24, called from /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/ofborg-evaluator-2/lib/customisation.nix:121:8:
anonymous function at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/ofborg-evaluator-2/pkgs/development/libraries/libjxl/default.nix:1:1 called without required argument 'pkgconfig', at /var/lib/ofborg/checkout/repo/38dca4e3aa6bca43ea96d2fcc04e8229/mr-est/ofborg-evaluator-2/lib/customisation.nix:69:16

According to @sternenseemann this means:

it doesn't evaluate with aliases turned off because pkgconfig is not the proper package name anymore, but an alias. you should use pkg-config with a dash instead

nh2 · 2021-06-22T22:52:47Z

aarch64-linux fails with:

In file included from /build/source/third_party/skcms/skcms.cc:2071:
/build/source/third_party/skcms/src/Transform_inl.h:619:25: internal compiler error: in instantiate_decl, at cp/pt.c:24602
  619 |     return cast<F>(lo|hi) * (1/65535.0f);
      |                         ^
Please submit a full bug report,

Reported at: libjxl/libjxl#213

nh2 · 2021-06-22T23:00:07Z

Ready to merge from my side.

For the internal compiler error failure on aarch64-linux failure in #103160 (comment), should I disable that arch, or leave it on so we can see if a future compiler upgrade will auto-fix it?

SuperSandro2000 · 2021-06-23T09:14:16Z

For the internal compiler error failure on aarch64-linux failure in #103160 (comment), should I disable that arch, or leave it on so we can see if a future compiler upgrade will auto-fix it?

Marking it broken saves hydra resources.

nh2 · 2021-06-23T11:27:59Z

Marking it broken saves hydra resources.

@SuperSandro2000 Thanks! Done.

pkgs/development/libraries/libjxl/default.nix

…ter default config Upstreamed in: NixOS#103160

ofborg bot added 8.has: package (new) 11.by: package-maintainer 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 labels Nov 8, 2020

SuperSandro2000 reviewed Nov 8, 2020

View reviewed changes

nh2 force-pushed the jpeg-xl branch from 3f073dd to 25d28a9 Compare November 8, 2020 22:44

nh2 force-pushed the jpeg-xl branch from 25d28a9 to 99f056b Compare November 12, 2020 15:25

FRidh added the 12.release: stable label Nov 21, 2020

stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 3, 2021

nh2 force-pushed the jpeg-xl branch from 99f056b to 812081a Compare June 22, 2021 16:38

stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 22, 2021

nh2 force-pushed the jpeg-xl branch from 812081a to b5f5311 Compare June 22, 2021 16:40

nh2 changed the base branch from release-20.09 to master June 22, 2021 16:41

github-actions bot removed 6.topic: vim 6.topic: golang 6.topic: python 6.topic: policy discussion 6.topic: ocaml labels Jun 22, 2021

nh2 marked this pull request as ready for review June 22, 2021 16:42

ofborg bot added the 2.status: merge conflict label Jun 22, 2021

nh2 force-pushed the jpeg-xl branch from b5f5311 to 3ddce24 Compare June 22, 2021 17:52

nh2 changed the title ~~jpeg-xl: init at 2020-10-29-8f2e0857~~ libjxl: init at 2021-06-22-409efe02 (jpeg-xl reference implementation) Jun 22, 2021

nh2 removed 12.branch: release-20.09 2.status: merge conflict labels Jun 22, 2021

SuperSandro2000 reviewed Jun 22, 2021

View reviewed changes

nh2 force-pushed the jpeg-xl branch from 3ddce24 to d8a1342 Compare June 22, 2021 18:20

nh2 force-pushed the jpeg-xl branch from d8a1342 to 90fa741 Compare June 22, 2021 18:24

nh2 mentioned this pull request Jun 22, 2021

build failure on aarch64-linux due to skcms triggering GCC internal compiler error libjxl/libjxl#213

Closed

libjxl: init at 2021-06-22-409efe02 (jpeg-xl reference implementation)

a7f0f57

nh2 force-pushed the jpeg-xl branch from 90fa741 to a7f0f57 Compare June 23, 2021 11:27

SuperSandro2000 reviewed Jun 26, 2021

View reviewed changes

pkgs/development/libraries/libjxl/default.nix Outdated Show resolved Hide resolved

Update pkgs/development/libraries/libjxl/default.nix

91ce104

SuperSandro2000 merged commit 85ff485 into NixOS:master Jun 26, 2021

Mindavi mentioned this pull request Sep 30, 2021

[staging-next] imagemagick: unbreak for aarch64 #140077

Merged

9 tasks

nh2 added a commit to nh2/nixpkgs that referenced this pull request Nov 18, 2021

NOT FOR UPSTREAM: xserver module: Make user-provided config render af…

7d0b1e7

…ter default config Upstreamed in: NixOS#103160

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

libjxl: init at 2021-06-22-409efe02 (jpeg-xl reference implementation) #103160

libjxl: init at 2021-06-22-409efe02 (jpeg-xl reference implementation) #103160

nh2 commented Nov 8, 2020 •

edited

nixos-discourse commented Nov 8, 2020

SuperSandro2000 Nov 8, 2020

nh2 Nov 8, 2020 •

edited

SuperSandro2000 Nov 9, 2020

nh2 Nov 25, 2020

nh2 Jun 22, 2021

SuperSandro2000 commented Nov 11, 2020 •

edited

SuperSandro2000 commented Nov 26, 2020

stale bot commented Jun 3, 2021

nh2 commented Jun 22, 2021

nh2 commented Jun 22, 2021 •

edited

nh2 commented Jun 22, 2021

nh2 commented Jun 22, 2021 •

edited

nh2 commented Jun 22, 2021

SuperSandro2000 commented Jun 23, 2021

nh2 commented Jun 23, 2021

libjxl: init at 2021-06-22-409efe02 (jpeg-xl reference implementation) #103160

libjxl: init at 2021-06-22-409efe02 (jpeg-xl reference implementation) #103160

Conversation

nh2 commented Nov 8, 2020 • edited

Motivation for this change

Things done

nixos-discourse commented Nov 8, 2020

SuperSandro2000 Nov 8, 2020

Choose a reason for hiding this comment

nh2 Nov 8, 2020 • edited

Choose a reason for hiding this comment

SuperSandro2000 Nov 9, 2020

Choose a reason for hiding this comment

nh2 Nov 25, 2020

Choose a reason for hiding this comment

nh2 Jun 22, 2021

Choose a reason for hiding this comment

SuperSandro2000 commented Nov 11, 2020 • edited

SuperSandro2000 commented Nov 26, 2020

stale bot commented Jun 3, 2021

nh2 commented Jun 22, 2021

nh2 commented Jun 22, 2021 • edited

nh2 commented Jun 22, 2021

nh2 commented Jun 22, 2021 • edited

nh2 commented Jun 22, 2021

SuperSandro2000 commented Jun 23, 2021

nh2 commented Jun 23, 2021

nh2 commented Nov 8, 2020 •

edited

nh2 Nov 8, 2020 •

edited

SuperSandro2000 commented Nov 11, 2020 •

edited

nh2 commented Jun 22, 2021 •

edited

nh2 commented Jun 22, 2021 •

edited