Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonModules.pyscard: 1.9.9 -> 2.0.0 #103122

Merged
merged 1 commit into from Nov 8, 2020
Merged

pythonModules.pyscard: 1.9.9 -> 2.0.0 #103122

merged 1 commit into from Nov 8, 2020

Conversation

lukegb
Copy link
Contributor

@lukegb lukegb commented Nov 8, 2020

Motivation for this change

Update pyscard to 2.0.0, needed by emv.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from layus November 8, 2020 10:52
@mweinelt
Copy link
Member

mweinelt commented Nov 8, 2020

Result of nixpkgs-review pr 103122 1

15 packages built:
  • electron-cash
  • electrum
  • electrum-ltc
  • gen-oath-safe
  • hwi (python38Packages.hwi)
  • python27Packages.btchip
  • python27Packages.pyscard
  • python37Packages.btchip
  • python37Packages.hwi
  • python37Packages.pyscard
  • python38Packages.btchip
  • python38Packages.pyscard
  • yubikey-manager
  • yubikey-manager-qt
  • yubioath-desktop

@mweinelt mweinelt merged commit 884d7ac into NixOS:master Nov 8, 2020
@lukegb lukegb deleted the update-pyscard branch December 5, 2022 01:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mweinelt mweinelt mweinelt approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

@layus layus Awaiting requested review from layus

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lukegb @mweinelt