Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] python3Packages.nixpkgs: unmark as broken #103151

Closed
wants to merge 2 commits into from
Closed

[20.09] python3Packages.nixpkgs: unmark as broken #103151

wants to merge 2 commits into from

Conversation

t184256
Copy link
Contributor

@t184256 t184256 commented Nov 8, 2020

Motivation for this change

I have no idea why it got marked broken (the same day I've checked it's OK), it's working fine.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member

FRidh commented Nov 8, 2020

Check all Python versions.

@t184256
Copy link
Contributor Author

t184256 commented Nov 8, 2020

@FRidh: oh, I see now!

pythonix dependency looks broken (builds, doesn't import) on all versions but 3.8, what should I do wrt that, mark pythonix conditionally broken and unmark this one? disable pythonix conditionally? disable this one conditionally?

cc @Mic92

@Mic92 @SuperSandro2000
Update pkgs/development/python-modules/nixpkgs/default.nix
4867cf7 
Co-authored-by: Sandro <sandro.jaeckel@gmail.com>
@Mic92
Copy link
Member

Mic92 commented Nov 8, 2020

@GrahamcOfBorg build python3Packages.nixpkgs

@t184256
Copy link
Contributor Author

t184256 commented Nov 15, 2020

Folks, I still am not sure what to do with that one. Guidance would be welcome.

@r-burns r-burns mentioned this pull request Jan 2, 2021
Merged
10 tasks
@stale
Copy link

stale bot commented Jun 3, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 3, 2021
@mweinelt
Copy link
Member

mweinelt commented Jul 5, 2021

Unfortunately NixOS 20.09 has reached its end-of-life status on 2021-07-01, one
month after the release of NixOS 21.05.

Since we do not accept any changes to its branches anymore, I'm closing this pull
request.

@mweinelt mweinelt closed this Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SuperSandro2000 SuperSandro2000 SuperSandro2000 left review comments

@FRidh FRidh Awaiting requested review from FRidh FRidh is a code owner

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: python 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@t184256 @FRidh @Mic92 @mweinelt @SuperSandro2000