-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Orthogonal decomposition #2783
Orthogonal decomposition #2783
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Strangely, the unit tests fail with major accuracy changes. This must be investigated.
PoissonSeriesBasisGenerator< | ||
Series, | ||
dimension, | ||
degree, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Put all 3 parameters on a single line, similar to line 98. In general, clang-format
doesn't do a great job with these templates...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same formatting comment, see line 169.
PoissonSeriesBasisGenerator< | ||
Series, | ||
dimension, | ||
degree, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same.
numerics/poisson_series_basis.hpp
Outdated
PoissonSeriesSubspace(PoissonSeriesSubspace&&) = default; | ||
|
||
PoissonSeriesSubspace& operator=(PoissonSeriesSubspace const&) = default; | ||
PoissonSeriesSubspace& operator=(PoissonSeriesSubspace&&) = default; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suspect that these 4 declarations could be removed.
PoissonSeriesBasisGenerator< | ||
Series, | ||
dimension, | ||
degree, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same formatting comment, see line 169.
std::index_sequence<indices...>>::Subspaces(Instant const& origin) { | ||
return {PoissonSeriesSubspace{ | ||
static_cast<PoissonSeriesSubspace::Coordinate>(indices % dimension), | ||
// The degree of the ith polynomial is i / dimension, so its parity is |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no i
, it's called indices
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, but this sentence is illegible if expressed in terms of a pack.
PoissonSeriesBasisGenerator< | ||
Series, | ||
dimension, | ||
degree, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same.
I can haz tests? |
It looks like this speeds up
AnalyticalSeriesTest.CompactRepresentation
between 10% and 20%.