Evolution ews: wrap evolution and evolution data server, fix nixos module. #103135

symphorien · 2020-11-08T13:45:41Z

Motivation for this change

Extends and replaces #92775

cc @dasJ @jtojnar

Things done

I've been using this for several weeks.

das-g · 2020-11-08T14:34:07Z

Did you mean to mention @dasj19 (author of #92775) rather than @dasJ?

symphorien · 2020-11-08T14:54:51Z

ah yes indeed, sorry :°

jtojnar · 2020-11-08T15:15:10Z

pkgs/top-level/all-packages.nix

@@ -20208,6 +20208,8 @@ in
  inherit (gnome3) evince;
  evolution-data-server = gnome3.evolution-data-server;
  evolution-ews = callPackage ../applications/networking/mailreaders/evolution/evolution-ews { };
+  evolution = callPackage ../applications/networking/mailreaders/evolution/evolution { };
+  evolutionBundle = callPackage ../applications/networking/mailreaders/evolution/evolution/wrapper.nix { };


This is non-standard naming that is not used anywhere. The -with-plugins is at least almost an idiom.

If we are to talk about naming: the problem is that this is rather an evolution-data-server-with-plugins. Where evolution somehow counts as a plugin. an evolutionWithPlugins which can possibly not contain evolution but only evolution-data-server would be somewhat strange. So I welcome better naming suggestions which can convey that.

pkgs/top-level/all-packages.nix

nixos/modules/services/desktops/gnome3/evolution-data-server.nix

symphorien · 2020-11-16T21:35:29Z

I solved the merge conflict.

symphorien · 2020-12-01T14:08:19Z

I solved anther merge conflict. I think the PR is ready now, and I've been using it successfully for some time now.

dasj19 · 2021-01-15T10:44:14Z

I tried running nix-shell -p nixpkgs-review --run "nixpkgs-review pr 103135" but I couldn't because of the conflicting files.
I'll try again once they get fixed.

symphorien · 2021-01-16T12:23:09Z

solved the merge conflict.
cc @jtojnar @worldofpeace to review the module.

dasj19 · 2021-01-16T17:28:00Z

I tested again, the evolution-with-plugins binary and it seems we are back to the problem described here: #92775 (comment)

symphorien · 2021-01-17T10:11:49Z

@dasj19 : you must ensure that you have installed no other software depending on evolution-data-server. This includes gnome-calendar for example. Also, because evolution-data-server has long running processes launched with ~~systemd~~ dbus, you should log out and login again after having activated the options in the module.

Edit sorry dasj for the wrong ping.

symphorien · 2021-01-17T10:12:20Z

I have been using this nearly daily for months now without a problem.

dasj19 · 2021-01-18T20:29:34Z

@symphorien I can not get it to work, I have installed evolutionWithPlugins and did a reboot afterwards. When I open evolution I can add an ews account but it does not show up in the list with accounts.
gnome-calendar is installed by default as part of gnome...

I do not know what else to try...

tolbrino · 2021-01-19T09:12:34Z

I've tested this PR on top of release-20.09 and it works nicely. Here are the respective configuration options used:

programs.evolution.enable = true;
programs.evolution.plugins = [ pkgs.evolution-ews ];
services.gnome3.evolution-data-server.enable = true;
services.gnome3.gnome-keyring.enable = true;
programs.seahorse.enable = true;

The setup of the O365 account was somewhat complicated due to tenant and application ids etc, but that is part of EWS.

Thanks for the effort. Really helpful.

dasj19 · 2021-01-19T12:03:06Z

@tolbrino Yes, it works with the options you provide. Thanks.

symphorien · 2021-01-20T18:47:04Z

Mmh enabling services.gnome3.gnome-keyring.enable = true; when evolution is enable makes sense, but is seahorse really required ?

tolbrino · 2021-01-21T08:00:28Z

Mmh enabling services.gnome3.gnome-keyring.enable = true; when evolution is enable makes sense, but is seahorse really required ?

This might just be on my end because GPG is used.

symphorien · 2021-02-26T19:06:38Z

I tried to upstream the patch to evolution, and upstream came up with a better solution. A simple wrapper with an environment variable without symlinkjoin will be available starting next release: https://gitlab.gnome.org/GNOME/evolution/-/merge_requests/77#note_1044591

symphorien mentioned this pull request Nov 8, 2020

WIP: Evolution with plugins #92775

Closed

10 tasks

ofborg bot added 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: nixos 6.topic: pantheon The Pantheon desktop environment 8.has: module (update) 8.has: clean-up 8.has: package (new) labels Nov 8, 2020

ofborg bot requested review from hedning, jtojnar and worldofpeace November 8, 2020 13:56

ofborg bot added 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 labels Nov 8, 2020

jtojnar reviewed Nov 8, 2020

View reviewed changes

pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved

symphorien force-pushed the pr/92775 branch from b67dda6 to 9b2ad51 Compare November 8, 2020 20:19

ofborg bot requested a review from jtojnar November 8, 2020 20:42

worldofpeace reviewed Nov 9, 2020

View reviewed changes

nixos/modules/services/desktops/gnome3/evolution-data-server.nix Outdated Show resolved Hide resolved

ofborg bot added 2.status: merge conflict and removed 6.topic: pantheon The Pantheon desktop environment labels Nov 10, 2020

symphorien force-pushed the pr/92775 branch from 90be8b9 to a16f4b4 Compare November 16, 2020 21:34

ofborg bot removed the 2.status: merge conflict label Nov 16, 2020

ofborg bot requested a review from worldofpeace November 16, 2020 22:00

symphorien force-pushed the pr/92775 branch from a16f4b4 to 5d2f21a Compare December 1, 2020 14:02

symphorien mentioned this pull request Dec 3, 2020

some applications from kde or gnome don't work when installed #105052

Closed

symphorien force-pushed the pr/92775 branch from 5d2f21a to ec156e2 Compare January 10, 2021 13:20

ofborg bot requested a review from dasj19 January 10, 2021 14:12

symphorien force-pushed the pr/92775 branch from ec156e2 to a95643c Compare January 16, 2021 12:01

dasj19 and others added 3 commits January 17, 2021 11:13

evolution-with-plugins: added support for evolution-ews.

e44b3c5

nixos: rework evolution-data-server module

d671677

almanah: fix evaluation

b241f7f

symphorien force-pushed the pr/92775 branch from a95643c to b241f7f Compare January 17, 2021 10:14

dasj19 approved these changes Jan 19, 2021

View reviewed changes

nixos/evolution: enable gnome-keyring

f45f22d

ofborg bot requested a review from dasj19 January 20, 2021 19:02

dasj19 approved these changes Jan 21, 2021

View reviewed changes

symphorien merged commit 7ed3d2d into NixOS:master Jan 21, 2021

This was referenced Feb 13, 2021

evolution-ews missing, needed for exchange support #12847

Closed

Packaging request / Help building: evolution-ews #67281

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Evolution ews: wrap evolution and evolution data server, fix nixos module. #103135

Evolution ews: wrap evolution and evolution data server, fix nixos module. #103135

symphorien commented Nov 8, 2020

das-g commented Nov 8, 2020

symphorien commented Nov 8, 2020

jtojnar Nov 8, 2020

symphorien Nov 8, 2020

symphorien commented Nov 16, 2020

symphorien commented Dec 1, 2020

dasj19 commented Jan 15, 2021

symphorien commented Jan 16, 2021

dasj19 commented Jan 16, 2021

symphorien commented Jan 17, 2021 •

edited

symphorien commented Jan 17, 2021

dasj19 commented Jan 18, 2021 •

edited

tolbrino commented Jan 19, 2021

dasj19 commented Jan 19, 2021

symphorien commented Jan 20, 2021

tolbrino commented Jan 21, 2021

symphorien commented Feb 26, 2021

Evolution ews: wrap evolution and evolution data server, fix nixos module. #103135

Evolution ews: wrap evolution and evolution data server, fix nixos module. #103135

Conversation

symphorien commented Nov 8, 2020

Motivation for this change

Things done

das-g commented Nov 8, 2020

symphorien commented Nov 8, 2020

jtojnar Nov 8, 2020

Choose a reason for hiding this comment

symphorien Nov 8, 2020

Choose a reason for hiding this comment

symphorien commented Nov 16, 2020

symphorien commented Dec 1, 2020

dasj19 commented Jan 15, 2021

symphorien commented Jan 16, 2021

dasj19 commented Jan 16, 2021

symphorien commented Jan 17, 2021 • edited

symphorien commented Jan 17, 2021

dasj19 commented Jan 18, 2021 • edited

tolbrino commented Jan 19, 2021

dasj19 commented Jan 19, 2021

symphorien commented Jan 20, 2021

tolbrino commented Jan 21, 2021

symphorien commented Feb 26, 2021

symphorien commented Jan 17, 2021 •

edited

dasj19 commented Jan 18, 2021 •

edited