Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/nix-daemon: fix extra-sandbox-paths warning #103137

Closed
wants to merge 1 commit into from
Closed

nixos/nix-daemon: fix extra-sandbox-paths warning #103137

wants to merge 1 commit into from

Conversation

Ma27
Copy link
Member

@Ma27 Ma27 commented Nov 8, 2020

Motivation for this change

See NixOS/nix@ff4dea6
for further context.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ma27 Ma27 requested a review from edolstra November 8, 2020 14:15
Ma27 referenced this pull request in NixOS/nix Nov 8, 2020
@edolstra
Generalize extra-* settings
ff4dea6 
This removes the extra-substituters and extra-sandbox-paths settings
and instead makes every array setting extensible by setting
"extra-<name> = <value>" in the configuration file or passing
"--<name> <value>" on the command line.
@Kha
Copy link
Contributor

Kha commented Nov 8, 2020

This will override Nix' built-in sandbox-paths (/bin/sh set to a custom busybox on Linux). When I tried the same setting, it turned out that this actually breaks Nix' own Nix build, which seems to depend on /bin/sh.

@Ma27
Copy link
Member Author

Ma27 commented Nov 8, 2020

Yeah I realized that this change is bogus, after a few test-builds weird things are happening locally. Not sure about a better fix, therefore will close for now.

@Ma27 Ma27 closed this Nov 8, 2020
@Ma27 Ma27 deleted the extra-sandbox-paths branch November 8, 2020 14:27
@Ericson2314
Copy link
Member

Per NixOS/nix@ff4dea6#commitcomment-43981658 I think config files should also support extra- just like the command line.

@edolstra
Copy link
Member

edolstra commented Nov 9, 2020

Config files do support extra-* so you can add to a global configuration setting in your own ~/.config/nix/nix.conf.

@Ma27
Copy link
Member Author

Ma27 commented Nov 9, 2020

@edolstra I get a warning that it's not supported though.

@edolstra
Copy link
Member

edolstra commented Nov 9, 2020

Turns out there was a bug in the handling of this setting which is fixed now (NixOS/nix@b87f84c).

@leotaku leotaku mentioned this pull request Nov 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Ma27 @Kha @Ericson2314 @edolstra