Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.jupytext: fix build by adding toml dep #103148

Closed
wants to merge 1 commit into from

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Nov 8, 2020

Note that we can't upgrade to 1.6.0 yet, since we must first package markdown-it-py:
https://github.com/mwouts/jupytext/blob/638895041e5a4c401636905a5dacb602a6b381fa/CHANGELOG.md#160-2020-09-01

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from timokau November 8, 2020 16:22
@bhipple bhipple added the 9.needs: port to stable A PR needs a backport to the stable release. label Nov 8, 2020
@bhipple
Copy link
Contributor Author

bhipple commented Nov 8, 2020

Verified that I can build this, and run a jupyter notebook with it and convert some of my notebooks

@jonringer
Copy link
Contributor

this is in staging c4e36c4

@jonringer
Copy link
Contributor

was done as part of stabilizing #101636

@bhipple
Copy link
Contributor Author

bhipple commented Nov 8, 2020

Oops; thanks for the sanity-check @jonringer !

@bhipple bhipple closed this Nov 8, 2020
@erictapen
Copy link
Member

I sort of backported this in 01c6a08..0c8eea8.

As only formerly broken packages were fixed or new packages were added, I figured this wouldn't have any negative impact on stabilty.

@erictapen erictapen added 8.has: port to stable A PR already has a backport to the stable release. and removed 9.needs: port to stable A PR needs a backport to the stable release. labels Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants