Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

buildPython*: remove pythonRecompileBytecodeHook as dependency #103089

Merged
merged 1 commit into from Nov 12, 2020
Merged

buildPython*: remove pythonRecompileBytecodeHook as dependency #103089

merged 1 commit into from Nov 12, 2020

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Nov 7, 2020

This hook was added to get reproducible bytecode. Because it was causing
issues it was disabled, but still kept as a dependency. Now the main
issue with bytecode reproducibility has been resolved by updating pip to
20.2.4, we remove this hook as a dependency.

If a package with Python code is not yet reproducible, one could add
this hook to nativeBuildInputs.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh
Copy link
Member Author

FRidh commented Nov 8, 2020

Need to remove occurrences of dontUsepythonRecompileBytecode.

@FRidh FRidh requested a review from jonringer as a code owner November 8, 2020 10:47
@jonringer
Copy link
Contributor

otherwise LGTM

@FRidh
buildPython*: remove pythonRecompileBytecodeHook as dependency
92f4183 
This hook was added to get reproducible bytecode. Because it was causing
issues it was disabled, but still kept as a dependency. Now the main
issue with bytecode reproducibility has been resolved by updating pip to
20.2.4, we remove this hook as a dependency.

If a package with Python code is not yet reproducible, one could add
this hook to `nativeBuildInputs`.
@FRidh FRidh added this to WIP in Staging via automation Nov 12, 2020
@FRidh FRidh merged commit 3fceafc into NixOS:staging Nov 12, 2020
Staging automation moved this from WIP to Done Nov 12, 2020
@FRidh FRidh mentioned this pull request Nov 15, 2020
Closed
29 tasks
@FRidh FRidh deleted the bytecode branch November 15, 2020 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@mt-caret mt-caret Awaiting requested review from mt-caret

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

@pSub pSub Awaiting requested review from pSub

@zimbatm zimbatm Awaiting requested review from zimbatm

Assignees
No one assigned
Labels
6.topic: python 8.has: documentation 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
Staging
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@FRidh @jonringer