Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make-test-python: disallow aliases #103074

Merged
merged 1 commit into from Jun 3, 2021
Merged

make-test-python: disallow aliases #103074

merged 1 commit into from Jun 3, 2021

Conversation

FRidh
Copy link
Member

@FRidh FRidh commented Nov 7, 2020 •
edited

When importing Nixpkgs within Nixpkgs, we should not consider aliases
to ensure we don't rely on them internally.

There are probably more places that need to be converted.

Triggered by #101369 (comment).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@FRidh FRidh requested review from tfc and ajs124 November 7, 2020 12:07
@FRidh
Copy link
Member Author

FRidh commented Nov 7, 2020

I expect evaluation errors.

@SuperSandro2000
Copy link
Member

I expect evaluation errors.

Ofborg thinks differently.

@FRidh
Copy link
Member Author

FRidh commented Nov 7, 2020

Need to add it to the machine configuration instead.

FRidh
FRidh commented Nov 7, 2020
View reviewed changes
nixos/lib/testing-python.nix Outdated Show resolved Hide resolved
@FRidh
Copy link
Member Author

FRidh commented Nov 7, 2020

@GrahamcOfBorg test plasma5

@FRidh FRidh added this to the 21.03 milestone Nov 7, 2020
@FRidh
make-test-python: disallow aliases
be8229a 
When importing Nixpkgs within Nixpkgs, we should not consider aliases
to ensure we don't rely on them internally.

There are probably more places that need to be converted.
@jonringer
Copy link
Contributor

@GrahamcOfBorg test installer

@jonringer
Copy link
Contributor

just wanted to run some tests to make sure it wasn't fundamentally broken

@jonringer jonringer merged commit 3edde65 into NixOS:master Jun 3, 2021
@lukegb lukegb mentioned this pull request Jun 4, 2021
Merged
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dasJ dasJ dasJ left review comments

@SuperSandro2000 SuperSandro2000 SuperSandro2000 approved these changes

@jonringer jonringer jonringer approved these changes

@Artturin Artturin Artturin approved these changes

@tfc tfc Awaiting requested review from tfc

@ajs124 ajs124 Awaiting requested review from ajs124

Assignees
No one assigned
Labels
6.topic: nixos 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
21.05
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@FRidh @SuperSandro2000 @jonringer @ajs124 @dasJ @Artturin