New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[20.09] gitAndTools.gh: 1.1.0 -> 1.2.0 #103079
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't squash the commits when cherry picking.
|
https://github.com/cli/cli/releases/tag/v1.2.0 (cherry picked from commit f2eb36b)
I don't get you, there is just the content of your commit? @SuperSandro2000 where do you get this? |
6893fef
to
1181c1a
Compare
@SuperSandro2000 that behavior probably exists on master, another PR should be done to correct the darwin build. |
1.0.0 -> 1.1.0 bedaefb and 1.1.0 -> 1.2.0 f2eb36b were squashed into one commit. @jonringer Why did you merge this when I had requested changes? |
hm, yes, that's my bad, there should have been two commits with too many reviews for one day... thought the chages were already applied for some reason, was probably thinking of a different PR |
Now it fetches the build from cache and I can't reproduce the build failure. |
Result of 1 package built:
|
Motivation for this change
Current version in 20.09 cannot create pull requests ...
https://github.com/cli/cli/releases/tag/v1.2.0
(cherry picked from commit f2eb36b)
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)