Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.09] gitAndTools.gh: 1.1.0 -> 1.2.0 #103079

Merged
merged 1 commit into from Nov 7, 2020

Conversation

freezeboy
Copy link
Contributor

Motivation for this change

Current version in 20.09 cannot create pull requests ...

https://github.com/cli/cli/releases/tag/v1.2.0
(cherry picked from commit f2eb36b)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Contributor

@zowoq zowoq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't squash the commits when cherry picking.

@SuperSandro2000
Copy link
Member

@nix { "action": "setPhase", "phase": "unpackPhase" }
unpacking sources
unpacking source archive /nix/store/azyprs63dm8hs4r3hg9qmyidhhs79bg1-source
source root is source
@nix { "action": "setPhase", "phase": "patchPhase" }
patching sources
@nix { "action": "setPhase", "phase": "configurePhase" }
configuring
@nix { "action": "setPhase", "phase": "buildPhase" }
building
make: /bin/sh: No such file or directory
make: /bin/sh: No such file or directory
make: *** [Makefile:30: bin/gh] Error 127

@freezeboy freezeboy changed the title gitAndTools.gh: 1.1.0 -> 1.2.0 [20.09] gitAndTools.gh: 1.1.0 -> 1.2.0 Nov 7, 2020
@freezeboy
Copy link
Contributor Author

Please don't squash the commits when cherry picking.

I don't get you, there is just the content of your commit?

@SuperSandro2000 where do you get this?

@jonringer jonringer merged commit 29cb4d0 into NixOS:release-20.09 Nov 7, 2020
@jonringer
Copy link
Contributor

@SuperSandro2000 that behavior probably exists on master, another PR should be done to correct the darwin build.

@freezeboy freezeboy deleted the update-hub-gh branch November 7, 2020 19:06
@zowoq
Copy link
Contributor

zowoq commented Nov 7, 2020

I don't get you, there is just the content of your commit?

1.0.0 -> 1.1.0 bedaefb and 1.1.0 -> 1.2.0 f2eb36b were squashed into one commit.


@jonringer Why did you merge this when I had requested changes?

@jonringer
Copy link
Contributor

jonringer commented Nov 7, 2020

hm, yes, that's my bad, there should have been two commits with -x

too many reviews for one day... thought the chages were already applied for some reason, was probably thinking of a different PR

@SuperSandro2000
Copy link
Member

Now it fetches the build from cache and I can't reproduce the build failure.

@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 103079 run on x86_64-darwin 1

1 package built:
  • github-cli (gitAndTools.gh)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants