Note the PAM upgrade is not really a possibility for 20.09.

This fixed kwallet issue on my system. Tested today.

According to SDDM upstream, we should not even be using their PAM configuration, it is provided only as an example. Also, it seems like the PAM update is not necessary for the fix?

@SCOTT-HAMILTON This PR currently can't be merged as the current version of pam master is higher than the one in this PR. Could you remove that change from the PR? :)

As for the sed command itself, I would not feel comfortable doing such a direct sed on the pam file, as it can very easily become a security liability, if an update to the configuration file starts relying on the fact that it is include and not substack. Could you instead copy the whole file, and maybe assert that upstream is the old file before using the new file instead? (or, alternatively, a patch that has as context the whole file would probably fit the bill too)

a patch that has as context the whole file would probably fit the bill too)

Good catch. I would prefer a patch.

Please do not merge branches into PRs to fix meme conflicts. Instead please use rebase.

I marked this as stale due to inactivity. → More info

I haven't seen this issue for a long time now (but I did see this issue a year ago too). Please reopen if it's still an issue and if this fix is still valid.

I'm running unstable, so it may be that I'm just lucky that I'm not experiencing this anymore.