Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

skrooge: Use default Qt version #103067

Closed
wants to merge 1 commit into from
Closed

skrooge: Use default Qt version #103067

wants to merge 1 commit into from

Conversation

alapshin
Copy link
Contributor

@alapshin alapshin commented Nov 7, 2020 •
edited

Motivation for this change

After PR #101369 was merged Skrooge uses different Qt version that other KDE applications. As a result Skrooge uses Fusion theme while all other applications use Breeze theme selected in KDE settings.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@freezeboy
Copy link
Contributor

PR #102840 also contains it

@alapshin
Copy link
Contributor Author

alapshin commented Nov 8, 2020

PR #102840 also contains it

Oh, my bad. I missed it somehow.

@alapshin alapshin closed this Nov 8, 2020
@alapshin alapshin deleted the skrooge branch November 8, 2020 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alapshin @freezeboy