Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

teamspeak_client: 3.5.3 -> 3.5.6 #103084

Merged
merged 1 commit into from Nov 26, 2020
Merged

teamspeak_client: 3.5.3 -> 3.5.6 #103084

merged 1 commit into from Nov 26, 2020

Conversation

lukegb
Copy link
Contributor

@lukegb lukegb commented Nov 7, 2020

Motivation for this change

Update Teamspeak client to 3.5.5 (mostly to stop annoying update nag boxes at startup).

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lukegb
Copy link
Contributor Author

lukegb commented Nov 7, 2020

@ofborg build teamspeak_client, pkgsi686Linux.teamspeak_client

@ofborg ofborg bot requested a review from nathanielbaxter November 7, 2020 14:06
@lukegb
Copy link
Contributor Author

lukegb commented Nov 7, 2020

Result of nixpkgs-review pr 103084 1

1 package built:
  • teamspeak_client

@lukegb
Copy link
Contributor Author

lukegb commented Nov 23, 2020

@SuperSandro2000 mind taking another look at this?

@lukegb lukegb marked this pull request as draft November 25, 2020 15:53
@lukegb
Copy link
Contributor Author

lukegb commented Nov 25, 2020

3.5.6 is out, updating this.

@lukegb lukegb changed the title teamspeak_client: 3.5.3 -> 3.5.5 teamspeak_client: 3.5.3 -> 3.5.6 Nov 25, 2020
@lukegb
Copy link
Contributor Author

lukegb commented Nov 25, 2020

Result of nixpkgs-review pr 103084 1

1 package built:
  • teamspeak_client

@lukegb lukegb marked this pull request as ready for review November 25, 2020 17:54
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 103084 run on x86_64-linux 1

1 package built:
  • teamspeak_client

@SuperSandro2000 SuperSandro2000 merged commit 5b71713 into NixOS:master Nov 26, 2020
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 103084 run on x86_64-linux 1

1 package built:
  • teamspeak_client

@lukegb lukegb deleted the ts3client branch November 26, 2020 00:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanielbaxter nathanielbaxter Awaiting requested review from nathanielbaxter

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lukegb @SuperSandro2000