haskell: Add documentationTarball to lib #103066
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Would you be willing to add a test for this? I'm imaging something similar to the |
cdepillabout
reviewed
Nov 7, 2020
| */ | ||
| documentationTarball = pkg: | ||
| pkgs.lib.overrideDerivation pkg (drv: { | ||
| name = "${drv.pname}-${drv.version}-docs"; |
There was a problem hiding this comment.
This is a pretty small nitpick, but couldn't this be
Suggested change
| name = "${drv.pname}-${drv.version}-docs"; | |
| name = "${drv.name}-docs"; |
And below as well.
expipiplus1
force-pushed
the
joe-hackage-docs
branch
2 times, most recently
from
f364819
to
54f07f2
Compare
I've added a test which checks for the presence of the haddocks themselves and the hyperlinked source. |
cdepillabout
reviewed
Nov 7, 2020
|
|
||
| in pkgs.runCommand "test haskell.lib.documentationTarball" { } '' | ||
| tar xvzf "${docs}/${drv.name}-docs.tar.gz" | ||
| files=$(find . -type f) |
There was a problem hiding this comment.
It looks like this isn't being used anywhere?
Suggested change
| files=$(find . -type f) |
Other than this, this PR looks good!
ofborg
bot
added
10.rebuild-linux: 1-10
10.rebuild-linux: 1
and removed
10.rebuild-linux: 0
labels
expipiplus1
force-pushed
the
joe-hackage-docs
branch
from
54f07f2
to
02a5994
Compare
|
oops, fixed
…On Sat, Nov 7, 2020 at 8:55 PM Dennis Gosnell ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In pkgs/test/haskell-documentationTarball/default.nix
<#103066 (comment)>:
> @@ -0,0 +1,18 @@
+{ pkgs, haskellPackages }:
+
+let
+ drv = haskellPackages.vector;
+ docs = pkgs.haskell.lib.documentationTarball drv;
+
+in pkgs.runCommand "test haskell.lib.documentationTarball" { } ''
+ tar xvzf "${docs}/${drv.name}-docs.tar.gz"
+ files=$(find . -type f)
It looks like this isn't being used anywhere?
⬇️ Suggested change
- files=$(find . -type f)
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#103066 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAGRJXHWR6A35QOGTGWGFX3SOU7SPANCNFSM4TNRUGIA>
.
|
cdepillabout
approved these changes
Nov 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
It's nice to be able to build this kind of thing with nix.
I've been using something similar for a few weeks without issue.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)