Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mypy: 0.782 -> 0.790 #103086

Merged
merged 1 commit into from Nov 7, 2020
Merged

mypy: 0.782 -> 0.790 #103086

merged 1 commit into from Nov 7, 2020

Conversation

seppeljordan
Copy link
Contributor

@seppeljordan seppeljordan commented Nov 7, 2020 •
edited

Motivation for this change

A new version of mypy is available upstream.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@seppeljordan
Copy link
Contributor Author

Result of nixpkgs-review pr 103086 1

2 packages marked as broken and skipped:
  • bareos
  • pepper
52 packages built:
  • ceph
  • ceph-client
  • errbot
  • fava
  • flexget
  • hydra-check (python38Packages.hydra-check)
  • libceph
  • mnemosyne
  • mypy (python38Packages.mypy)
  • nix-pin
  • python37Packages.WSME
  • python37Packages.algebraic-data-types
  • python37Packages.cheroot
  • python37Packages.cherrypy
  • python37Packages.hydra-check
  • python37Packages.ics
  • python37Packages.irc
  • python37Packages.jaraco_logging
  • python37Packages.mypy
  • python37Packages.portend
  • python37Packages.pyalgotrade
  • python37Packages.pyls-mypy
  • python37Packages.pynamodb
  • python37Packages.pytest-mypy
  • python37Packages.tatsu
  • python37Packages.tempora
  • python37Packages.typer
  • python37Packages.ws4py
  • python37Packages.zerobin
  • python38Packages.WSME
  • python38Packages.algebraic-data-types
  • python38Packages.cheroot
  • python38Packages.cherrypy
  • python38Packages.ics
  • python38Packages.irc
  • python38Packages.jaraco_logging
  • python38Packages.portend
  • python38Packages.pyalgotrade
  • python38Packages.pyls-mypy
  • python38Packages.pynamodb
  • python38Packages.pytest-mypy
  • python38Packages.tatsu
  • python38Packages.tempora
  • python38Packages.typer
  • python38Packages.ws4py
  • python38Packages.zerobin
  • sabnzbd
  • samba4Full
  • thonny
  • tribler
  • ulauncher
  • zfs-replicate

@ofborg ofborg bot requested review from martingms and LnL7 November 7, 2020 14:18
@seppeljordan
Copy link
Contributor Author

result/bin/mypyc does not work, but it also does not work on master branch.

jonringer
jonringer approved these changes Nov 7, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 103086 1

2 packages marked as broken and skipped:
  • bareos
  • pepper
1 package blacklisted:
  • tests.nixos-functions.nixosTest-test
52 packages built:
  • ceph (ceph-dev)
  • ceph-client
  • errbot
  • fava
  • flexget
  • hydra-check (python38Packages.hydra-check)
  • libceph
  • mnemosyne
  • mypy (python38Packages.mypy)
  • nix-pin
  • python37Packages.WSME
  • python37Packages.algebraic-data-types
  • python37Packages.cheroot
  • python37Packages.cherrypy
  • python37Packages.hydra-check
  • python37Packages.ics
  • python37Packages.irc
  • python37Packages.jaraco_logging
  • python37Packages.mypy
  • python37Packages.portend
  • python37Packages.pyalgotrade
  • python37Packages.pyls-mypy
  • python37Packages.pynamodb
  • python37Packages.pytest-mypy
  • python37Packages.tatsu
  • python37Packages.tempora
  • python37Packages.typer
  • python37Packages.ws4py
  • python37Packages.zerobin
  • python38Packages.WSME
  • python38Packages.algebraic-data-types
  • python38Packages.cheroot
  • python38Packages.cherrypy
  • python38Packages.ics
  • python38Packages.irc
  • python38Packages.jaraco_logging
  • python38Packages.portend
  • python38Packages.pyalgotrade
  • python38Packages.pyls-mypy
  • python38Packages.pynamodb
  • python38Packages.pytest-mypy
  • python38Packages.tatsu
  • python38Packages.tempora
  • python38Packages.typer
  • python38Packages.ws4py
  • python38Packages.zerobin
  • sabnzbd
  • sambaFull (samba4Full)
  • thonny
  • tribler
  • ulauncher
  • zfs-replicate

@jonringer jonringer merged commit 4e81c65 into NixOS:master Nov 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

@martingms martingms Awaiting requested review from martingms

@LnL7 LnL7 Awaiting requested review from LnL7

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@seppeljordan @jonringer