Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

makemkv: add jre_headless PATH through the wrapper #103085

Merged
merged 2 commits into from Nov 12, 2020
Merged

makemkv: add jre_headless PATH through the wrapper #103085

merged 2 commits into from Nov 12, 2020

Conversation

danieldk
Copy link
Contributor

@danieldk danieldk commented Nov 7, 2020

Motivation for this change

MakeMKV requires a Java runtime environment to extract some Blu-ray
disks:

http://www.makemkv.com/bdjava/

This change provides jre_headless by default.

This PR also adds a commit to clean up the formatting of the
derivation a little and to replace the pkgconfig alias by
pkg-config.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danieldk
makemkv: fix formatting and replace pkgconfig alias
6c9aaf2
@danieldk
makemkv: add jre_headless PATH through the wrapper
83e9cc4 
MakeMKV requires a Java runtime environment to extract some Blu-ray
disks:

http://www.makemkv.com/bdjava/

This change provides jre_headless by default.
@ofborg ofborg bot requested a review from titanous November 7, 2020 14:11
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/366

@titanous
Copy link
Contributor

Does this work for makemkvcon?

@danieldk
Copy link
Contributor Author

Does this work for makemkvcon?

Yes:

❯ grep "headless" result/bin/makemkvcon    
export PATH='/nix/store/sdwcd89l0l1pvibypfxv5vvj8v6p6lc9-openjdk-headless-14.0.2-ga/bin'${PATH:+':'}$PATH

But this is a side-effect of makemkvcon being Qt-wrapped, which it probably shouldn't.

@danieldk
Copy link
Contributor Author

Thanks for reviewing!

@danieldk danieldk merged commit e2db0ee into NixOS:master Nov 12, 2020
@danieldk danieldk deleted the makemkv-jre branch November 12, 2020 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@titanous titanous titanous approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@danieldk @nixos-discourse @titanous