Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stdenv: Fix error message when checkPhase is missing #103068

Merged
merged 1 commit into from Nov 7, 2020
Merged

stdenv: Fix error message when checkPhase is missing #103068

merged 1 commit into from Nov 7, 2020

Conversation

nomeata
Copy link
Contributor

@nomeata nomeata commented Nov 7, 2020

No description provided.

@SuperSandro2000
Copy link
Member

Can you target staging? This change is very little but it rebuilds a lot.

@nomeata nomeata changed the base branch from master to staging November 7, 2020 15:41
@nomeata
Copy link
Contributor Author

nomeata commented Nov 7, 2020

Rebased to staging

jonringer
jonringer approved these changes Nov 7, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder how long this has been this way.

Thanks!

@jonringer jonringer merged commit d92a19b into NixOS:staging Nov 7, 2020
@nomeata
Copy link
Contributor Author

nomeata commented Nov 7, 2020

I wonder how long this has been this way.

Since 50af975, (git blame is a squealer)

@nomeata nomeata deleted the phase-error-msg branch November 7, 2020 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer approved these changes

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314 Ericson2314 is a code owner

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@alyssais alyssais Awaiting requested review from alyssais

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
2.status: merge conflict 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: haskell 6.topic: nixos 6.topic: pantheon The Pantheon desktop environment 6.topic: python 6.topic: ruby 6.topic: stdenv Standard environment 8.has: changelog 8.has: documentation 8.has: module (update) 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 10.rebuild-linux-stdenv
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nomeata @SuperSandro2000 @jonringer