ocamlPackages.digestif: 0.8.0 → 0.9.0 #103082
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@GrahamcOfBorg build ocamlPackages.irmin-unix |
| propagatedBuildInputs = [ bigarray-compat eqaf stdlib-shims ]; | ||
|
|
||
| doCheck = true; | ||
| checkInputs = [ alcotest ]; |
There was a problem hiding this comment.
digestif.opam lists bos, astring, fpath, rresult as test dependencies and findlib as build dependency. Maybe sensible to add the explicitly instead of relying on propagation?
There was a problem hiding this comment.
Maybe the digestif.opam is out of date?
There was a problem hiding this comment.
Seems to be necessary for https://github.com/mirage/digestif/blob/f97216b8f3a501c8f0197be338ce85145fb46443/test/test_runes.ml. Seems like this test is invoked separately which we could (should?) do as well.
There was a problem hiding this comment.
Well spotted. I’ve thus added a postCheck attribute to run that lone test explicitly.
vbgl
force-pushed
the
ocaml-digestif-0.9.0
branch
from
9eb43ba
to
ac793a0
Compare
sternenseemann
approved these changes
Nov 13, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
SHA3: https://github.com/mirage/digestif/releases/tag/v0.9.0
Use Dune 2.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)