Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dasel: 1.1.0 -> 1.2.0 #103072

Merged
merged 1 commit into from Nov 7, 2020
Merged

dasel: 1.1.0 -> 1.2.0 #103072

merged 1 commit into from Nov 7, 2020

Conversation

0x4A6F
Copy link
Member

@0x4A6F 0x4A6F commented Nov 7, 2020

Motivation for this change

Upgrade to 1.2.0

  • Add support for YAML multi-document files
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

- Add support for YAML multi-document files
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 103072 1

1 package built:
  • dasel

@danieldk danieldk merged commit b1ae1e5 into NixOS:master Nov 7, 2020
@SuperSandro2000
Copy link
Member

Result of nixpkgs-review pr 103072 run on x86_64-darwin 1

1 package built:
  • dasel

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants