Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[20.09] thunderbird, thunderbird-bin: 78.4.0 -> 78.4.1 #103075

Merged
merged 2 commits into from Nov 8, 2020
Merged

[20.09] thunderbird, thunderbird-bin: 78.4.0 -> 78.4.1 #103075

merged 2 commits into from Nov 8, 2020

Conversation

taku0
Copy link
Contributor

@taku0 taku0 commented Nov 7, 2020 •
edited

Motivation for this change

#103069 for 20.09.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@taku0
thunderbird-bin: 78.4.0 -> 78.4.1
0138ba6 
(cherry picked from commit 33a3ac3)
@taku0
thunderbird: 78.4.0 -> 78.4.1
66c5e26 
(cherry picked from commit 00213ef)
(with tweak)
@taku0
Copy link
Contributor Author

taku0 commented Nov 8, 2020

It works fine.

vcunat
vcunat reviewed Nov 8, 2020
View reviewed changes
pkgs/top-level/all-packages.nix
inherit (rustPackages_1_44) cargo rustc;
# Using older Rust for workaround:
# https://bugzilla.mozilla.org/show_bug.cgi?id=1663715
inherit (rustPackages_1_45) cargo rustc;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, default version of rust will surely remain constant on stable branches (and is 1.45 now) and the diff looks a little self-contradictory here ("using older" upgrade)... but I actually don't see any problem in keeping this PR as it is.

@vcunat vcunat merged commit f2c57a4 into NixOS:release-20.09 Nov 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat left review comments

@lovesegfault lovesegfault lovesegfault approved these changes

@edolstra edolstra Awaiting requested review from edolstra

@nbp nbp Awaiting requested review from nbp

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@taku0 @vcunat @lovesegfault