Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vimPlugins: fix coc-markdownlint and coc-vimlsp #105174

Merged
merged 5 commits into from Nov 27, 2020
Merged

Conversation

malob
Copy link
Member

@malob malob commented Nov 27, 2020

Motivation for this change

I use Nix to manage my Neovim installation (including plugins) and configuration. In my Neovim setup I use coc.vim, and plugins for that ecosystem. I noticed some coc.nvim plugins that I use, coc-markdownlint and coc-vimlsp, that are available in nixpkgs where not recognized by coc.nvim when installed through Nix.

Things done

These plugins were being added to nixpkgs using the vim-plugins-names\update.py mechanism, as opposed to other coc.nvim plugins (that were recognized when installed through Nix) that are added through nodePackages and override.nix for Vim plugins.

To resolve the issue of the two plugins in question not being recognized, I transitioned them to using the latter mechanism.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@malob
Copy link
Member Author

malob commented Nov 27, 2020

It's worth noting that there are other coc.nvim plugins that might also suffer from the same issue, that I didn't "fix" with this PR since I don't personally use them. They are:

  • coc-clap
  • coc-denite
  • coc-explorer
  • coc-fzf
  • coc-neco
  • coc-spell-checker

@SuperSandro2000
Copy link
Member

and already a merge conflict.

@malob
Copy link
Member Author

malob commented Nov 27, 2020

Resolved.

Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 105174 1

3 packages marked as broken and skipped:
  • rambox-pro
  • sage
  • sageWithDoc
20 packages built:
  • castnow
  • create-cycle-app
  • epgstation
  • etcher
  • gtop
  • joplin
  • lumo
  • mirakurun
  • netlify-cli
  • parity-ui
  • pm2
  • redoc-cli
  • slack
  • teleprompter
  • thelounge
  • vimPlugins.coc-markdownlint
  • vimPlugins.coc-prettier
  • vimPlugins.coc-stylelint
  • vimPlugins.coc-vimlsp
  • vscode-extensions.matklad.rust-analyzer

@jonringer jonringer merged commit da8bd77 into NixOS:master Nov 27, 2020
@malob malob deleted the coc-plugins branch November 27, 2020 23:20
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/cant-get-neovim-plugin-coc-explorer-working/11653/8

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants