vimPlugins: fix coc-markdownlint and coc-vimlsp #105174
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It's worth noting that there are other
|
ofborg
bot
added
6.topic: vim
2.status: merge conflict
|
and already a merge conflict. |
|
Resolved. |
ofborg
bot
removed
the
2.status: merge conflict
jonringer
approved these changes
Nov 27, 2020
There was a problem hiding this comment.
LGTM
Result of nixpkgs-review pr 105174 1
3 packages marked as broken and skipped:
- rambox-pro
- sage
- sageWithDoc
20 packages built:
- castnow
- create-cycle-app
- epgstation
- etcher
- gtop
- joplin
- lumo
- mirakurun
- netlify-cli
- parity-ui
- pm2
- redoc-cli
- slack
- teleprompter
- thelounge
- vimPlugins.coc-markdownlint
- vimPlugins.coc-prettier
- vimPlugins.coc-stylelint
- vimPlugins.coc-vimlsp
- vscode-extensions.matklad.rust-analyzer
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/cant-get-neovim-plugin-coc-explorer-working/11653/8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
I use Nix to manage my Neovim installation (including plugins) and configuration. In my Neovim setup I use
coc.vim, and plugins for that ecosystem. I noticed somecoc.nvimplugins that I use,coc-markdownlintandcoc-vimlsp, that are available innixpkgswhere not recognized bycoc.nvimwhen installed through Nix.Things done
These plugins were being added to
nixpkgsusing thevim-plugins-names\update.pymechanism, as opposed to othercoc.nvimplugins (that were recognized when installed through Nix) that are added throughnodePackagesandoverride.nixfor Vim plugins.To resolve the issue of the two plugins in question not being recognized, I transitioned them to using the latter mechanism.
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)